feat(segment-enrichment): Bump segment clusterer rule lifetimes

[mjq]

Last in a series of PRs (#103739, #103913, #104192) to port transaction name clustering to segment enrichment for segments.

This adds the final step, bumping lifetime rules after their application. Since the arguments for transactions and segments are different, refactored the existing _bump_rule_lifetime into two entry points that munge arguments before passing them to the existing logic.

[sentry]

Bug: applied_rules on line 191 defaults to a dictionary ({}) instead of a list ([]), causing a type mismatch with expected Sequence iteration.
_{Severity: MEDIUM | Confidence: High}

🔍 Detailed Analysis

On line 191 of src/sentry/ingest/transaction_clusterer/datasource/redis.py, the applied_rules variable defaults to an empty dictionary ({}) when the rem field is absent from transaction event data. This creates a type mismatch because the code expects applied_rules to be a Sequence (specifically a list) for iteration, as evidenced by test data, type annotations, and the loop logic on lines 210-217. This inconsistency with the segment case (line 200, which defaults to []) means that if a non-empty dictionary is ever provided, the iteration logic will fail.

💡 Suggested Fix

Change the default value for applied_rules on line 191 from {} to [] to align with the expected Sequence type and the segment implementation.

🤖 Prompt for AI Agent

Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: src/sentry/ingest/transaction_clusterer/datasource/redis.py#L191

Potential issue: On line 191 of
`src/sentry/ingest/transaction_clusterer/datasource/redis.py`, the `applied_rules`
variable defaults to an empty dictionary (`{}`) when the `rem` field is absent from
transaction event data. This creates a type mismatch because the code expects
`applied_rules` to be a `Sequence` (specifically a list) for iteration, as evidenced by
test data, type annotations, and the loop logic on lines 210-217. This inconsistency
with the segment case (line 200, which defaults to `[]`) means that if a non-empty
dictionary is ever provided, the iteration logic will fail.

_{Did we get this right? 👍 / 👎 to inform future reviews.
Reference ID: 4996900}

[cursor]

Bug: Missing null check before parsing JSON metadata

The _bump_rule_lifetime_for_segment function calls attribute_value which returns None when the requested attribute doesn't exist on the span. The result is immediately passed to orjson.loads(meta_str) without a null check, which will raise a TypeError when meta_str is None. This occurs when a segment span hasn't had any clustering rules applied to it (e.g., new segment name patterns before rules are generated). While safe_execute catches the exception, this causes unnecessary errors rather than gracefully handling the case where no rules were applied.