Skip to content

feat(dashboards): add legend to queries module charts #103752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 21, 2025
Merged

feat(dashboards): add legend to queries module charts #103752

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0c53c94
add legend to queries module dashboard
DominikB2014 Nov 20, 2025
17593e1
add legend to queries module dashboard
DominikB2014 Nov 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions static/app/views/dashboards/utils/prebuiltConfigs.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import {type DashboardDetails} from 'sentry/views/dashboards/types';
import {QUERIES_PREBUILT_CONFIG} from 'sentry/views/dashboards/utils/prebuiltConfigs/queries';
import {QUERIES_SUMMARY_PREBUILT_CONFIG} from 'sentry/views/dashboards/utils/prebuiltConfigs/querySummary';
import {QUERIES_PREBUILT_CONFIG} from 'sentry/views/dashboards/utils/prebuiltConfigs/queries/queries';
import {QUERIES_SUMMARY_PREBUILT_CONFIG} from 'sentry/views/dashboards/utils/prebuiltConfigs/queries/querySummary';
import {SESSION_HEALTH_PREBUILT_CONFIG} from 'sentry/views/dashboards/utils/prebuiltConfigs/sessionHealth';

export enum PrebuiltDashboardId {
Expand Down
4 changes: 4 additions & 0 deletions static/app/views/dashboards/utils/prebuiltConfigs/queries/constants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
import {t} from 'sentry/locale';

export const QUERIES_PER_MINUTE_TEXT = t('Queries Per Minute');
export const AVERAGE_DURATION_TEXT = t('Average Duration');
8 changes: 6 additions & 2 deletions ...shboards/utils/prebuiltConfigs/queries.ts → .../utils/prebuiltConfigs/queries/queries.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,10 @@ import {FieldKind} from 'sentry/utils/fields';
import {MutableSearch} from 'sentry/utils/tokenizeSearch';
import {DisplayType, WidgetType} from 'sentry/views/dashboards/types';
import type {PrebuiltDashboard} from 'sentry/views/dashboards/utils/prebuiltConfigs';
import {
AVERAGE_DURATION_TEXT,
QUERIES_PER_MINUTE_TEXT,
} from 'sentry/views/dashboards/utils/prebuiltConfigs/queries/constants';
import {DataTitles} from 'sentry/views/insights/common/views/spans/types';
import {EXCLUDED_DB_OPS} from 'sentry/views/insights/database/settings';
import {ModuleName, SpanFields} from 'sentry/views/insights/types';
Expand Down Expand Up @@ -60,7 +64,7 @@ export const QUERIES_PREBUILT_CONFIG: PrebuiltDashboard = {
interval: '',
queries: [
{
name: '',
name: QUERIES_PER_MINUTE_TEXT,
conditions: FILTER_STRING,
fields: ['epm()'],
aggregates: ['epm()'],
Expand All @@ -84,7 +88,7 @@ export const QUERIES_PREBUILT_CONFIG: PrebuiltDashboard = {
interval: '',
queries: [
{
name: '',
name: AVERAGE_DURATION_TEXT,
conditions: FILTER_STRING,
fields: [`avg(${SpanFields.SPAN_SELF_TIME})`],
aggregates: [`avg(${SpanFields.SPAN_SELF_TIME})`],
Expand Down
12 changes: 8 additions & 4 deletions ...rds/utils/prebuiltConfigs/querySummary.ts → ...s/prebuiltConfigs/queries/querySummary.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@ import {t} from 'sentry/locale';
import {FieldKind} from 'sentry/utils/fields';
import {DisplayType, WidgetType} from 'sentry/views/dashboards/types';
import type {PrebuiltDashboard} from 'sentry/views/dashboards/utils/prebuiltConfigs';
import {
AVERAGE_DURATION_TEXT,
QUERIES_PER_MINUTE_TEXT,
} from 'sentry/views/dashboards/utils/prebuiltConfigs/queries/constants';
import {SpanFields} from 'sentry/views/insights/types';

export const QUERIES_SUMMARY_PREBUILT_CONFIG: PrebuiltDashboard = {
Expand Down Expand Up @@ -33,14 +37,14 @@ export const QUERIES_SUMMARY_PREBUILT_CONFIG: PrebuiltDashboard = {
widgets: [
{
id: 'metrics-throughput',
title: t('Queries Per Minute'),
title: QUERIES_PER_MINUTE_TEXT,
description: '',
displayType: DisplayType.BIG_NUMBER,
thresholds: null,
interval: '1h',
queries: [
{
name: '',
name: QUERIES_PER_MINUTE_TEXT,
fields: ['epm()'],
aggregates: ['epm()'],
columns: [],
Expand All @@ -60,14 +64,14 @@ export const QUERIES_SUMMARY_PREBUILT_CONFIG: PrebuiltDashboard = {
},
{
id: 'metrics-duration',
title: 'Avg Duration',
title: AVERAGE_DURATION_TEXT,
description: '',
displayType: DisplayType.BIG_NUMBER,
thresholds: null,
interval: '1h',
queries: [
{
name: '',
name: AVERAGE_DURATION_TEXT,
fields: [`avg(${SpanFields.SPAN_SELF_TIME})`],
aggregates: [`avg(${SpanFields.SPAN_SELF_TIME})`],
columns: [],
Expand Down
Loading