Skip to content

feat(charts): Custom icons for legends #103800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 21, 2025
Merged

feat(charts): Custom icons for legends #103800

merged 1 commit into from
Nov 21, 2025
+9 −2

Conversation

@evanpurkhiser
Copy link
Member

@evanpurkhiser evanpurkhiser commented Nov 21, 2025 •
edited
Loading

Looks like this

clipboard.png

clipboard.png

image

@evanpurkhiser evanpurkhiser requested a review from a team as a code owner November 21, 2025 02:16
@evanpurkhiser evanpurkhiser requested review from a team and removed request for a team November 21, 2025 02:16
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Nov 21, 2025
Jesse-Box
Jesse-Box requested changes Nov 21, 2025
View reviewed changes
Copy link
Contributor

@Jesse-Box Jesse-Box left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@evanpurkhiser good start!

Ideally, if you toggle the checkboxes, the checkbox tick is hidden. Additionally, the background gray used for the "off" state is lighter. Try gray300, its probably a bit too light, but new colors are coming in the next two weeks so we can do another pass then.

Thanks man

@evanpurkhiser
Copy link
Member Author

evanpurkhiser commented Nov 21, 2025

Ideally, if you toggle the checkboxes, the checkbox tick is hidden

I strongly agree. Unfortunately this is not easy in the current implementation. I think we'll need to rebuild the whole legend stuff into a react component (which it sounds like @gggritso is planning to do)

Try gray300, its probably a bit too light

I tried, it's too light\

I think we should try and merge this now as is, since it's definitely a clear improvement.

@evanpurkhiser
feat(charts): Custom icons for legends
e8fd0b5 
Looks like this

<img alt="clipboard.png" width="625" src="https://i.imgur.com/KXaQkJi.png" />

<img alt="clipboard.png" width="246" src="https://i.imgur.com/eO4nRHJ.png" />

<img alt="clipboard.png" width="453" src="https://i.imgur.com/2GZRWVX.png" />
@evanpurkhiser evanpurkhiser force-pushed the evanpurkhiser/feat-charts-custom-icons-for-legends branch from ed07c3b to e8fd0b5 Compare November 21, 2025 19:55
@evanpurkhiser evanpurkhiser merged commit f08713f into master Nov 21, 2025
48 checks passed
@evanpurkhiser evanpurkhiser deleted the evanpurkhiser/feat-charts-custom-icons-for-legends branch November 21, 2025 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Jesse-Box Jesse-Box Jesse-Box approved these changes

Assignees

No one assigned

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@evanpurkhiser @Jesse-Box