fix(monitors): Allow editing cron monitor detectors with existing slug #103846
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #103846 +/- ##
===========================================
- Coverage 80.62% 80.61% -0.01%
===========================================
Files 9287 9287
Lines 396357 396390 +33
Branches 25259 25259
===========================================
+ Hits 319544 319550 +6
- Misses 76353 76380 +27
Partials 460 460 |
Fixed [NEW-648: Cron detectors can't be edited due to error](https://linear.app/getsentry/issue/NEW-648/cron-detectors-cant-be-edited-due-to-error) When updating a cron monitor detector with dataSources in the request body, the slug validation was incorrectly rejecting the existing slug as "already in use". This occurred because the MonitorDataSourceValidator nested in a ListField didn't have its instance property set during validation. Created MonitorDataSourceListField to bind the Monitor instance to child validators before validation runs, allowing the slug check to recognize updates vs creates.
evanpurkhiser
force-pushed
the
evanpurkhiser/fix-monitors-allow-editing-cron-monitor-detectors-with-existing-slug
branch
from
1940b99 to
cc636f4
Compare
wedamija
approved these changes
Nov 21, 2025
|
|
||
| def to_internal_value(self, data): | ||
| # If we're updating (parent has instance), bind the Monitor instance to child validator | ||
| if hasattr(self.parent, "instance") and self.parent.instance: |
Member
There was a problem hiding this comment.
I think this could just be if getattr(self.parent, "instance", None)
evanpurkhiser
deleted the
evanpurkhiser/fix-monitors-allow-editing-cron-monitor-detectors-with-existing-slug
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed NEW-648: Cron detectors can't be edited due to error
When updating a cron monitor detector with dataSources in the request body,
the slug validation was incorrectly rejecting the existing slug as "already
in use". This occurred because the MonitorDataSourceValidator nested in a
ListField didn't have its instance property set during validation.
Created MonitorDataSourceListField to bind the Monitor instance to child
validators before validation runs, allowing the slug check to recognize
updates vs creates.