chore(aci): remove lastChecked from open period serializer #103868
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
kcons
approved these changes
Nov 21, 2025
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| from sentry.api.serializers import Serializer, register, serialize | ||
| from sentry.incidents.utils.process_update_helpers import calculate_event_date_from_update_date | ||
| from sentry.models.groupopenperiod import GroupOpenPeriod, get_last_checked_for_open_period | ||
| from sentry.models.groupopenperiod import GroupOpenPeriod |
Contributor
There was a problem hiding this comment.
Bug: Frontend still expects removed lastChecked field
The lastChecked field was removed from GroupOpenPeriodResponse and the serializer, but the frontend code at static/app/views/issueDetails/streamline/sidebar/firstLastSeenSection.tsx still accesses openPeriods?.[0]?.lastChecked to determine the last seen time. This causes the frontend to always fall back to group.lastSeen instead of the intended value, breaking the "Last seen" display for issues using open period checks.
Member
There was a problem hiding this comment.
This is fine, it falls back the group.lastSeen if it's not there, though we should followup and remove it from the expected type
malwilley
approved these changes
Nov 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is causing requests to be incredibly slow. Since we don't need this on every open period, remove it from the serializer and figure out a different way to populate lastSeen.