chore(feedback): Prefer <FeedbackButton> over useFeedbackForm() #103916
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
❌ 46 Tests Failed:
View the top 3 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
![sentry[bot]](https://avatars.githubusercontent.com/u/1396951?s=60&v=4){kind=small}
malwilley
approved these changes
Nov 25, 2025
| }, | ||
| }} | ||
| > | ||
| {undefined} |
Member
Author
There was a problem hiding this comment.
ya, need to override the default string :(
there's two places that do this for "👍 👎 " buttons. We could probably make that pair a helper in it's own right and improve this.
Member
Author
There was a problem hiding this comment.
i'll follow up with that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates most of the callsites to use
<FeedbackButton>when before it was usinguseFeedbackForm().The element is easier to use than the hook, takes less code and has reasonable defaults that will save you time and extra code. By having most of the examples in the app use the easier element form, people should be copy+pasting the better form, and the LLMS will hopefully prefer it too.
Along the way i noticed a few places that were not translating strings, and/or passing inappropriate stuff to data-aria-label. This is cleaned up. There are more spots in these same files that are missing translations, but i only changed things related to feedback.
I tweaked the FeedbackButton itself so it can better behave as an icon-only button. The Thumbs Up/Down pattern is used twice that i found.
There's a few other places that still call
useFeedbackForm()directly, some can be changed over (bug i didn't find them in the app to test them out) while others are like menu items and stuff that don't need to use a Button.