feat(explore-attr-breakdowns): Persisting search #103918
+236
−89
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -10,13 +10,13 @@ import {Flex} from '@sentry/scraps/layout'; | |
| import type {Selection} from 'sentry/components/charts/useChartXRangeSelection'; | ||
| import {Text} from 'sentry/components/core/text'; | ||
| import LoadingError from 'sentry/components/loadingError'; | ||
| import Panel from 'sentry/components/panels/panel'; | ||
| import BaseSearchBar from 'sentry/components/searchBar'; | ||
| import {IconChevron} from 'sentry/icons/iconChevron'; | ||
| import {t} from 'sentry/locale'; | ||
| import {space} from 'sentry/styles/space'; | ||
| import {getUserTimezone} from 'sentry/utils/dates'; | ||
| import {useQueryParamState} from 'sentry/utils/url/useQueryParamState'; | ||
| import {useDebouncedValue} from 'sentry/utils/useDebouncedValue'; | ||
| import useAttributeBreakdownComparison from 'sentry/views/explore/hooks/useAttributeBreakdownComparison'; | ||
| import {useQueryParamsVisualizes} from 'sentry/views/explore/queryParams/context'; | ||
|
|
@@ -46,14 +46,16 @@ export function CohortComparison({ | |
| aggregateFunction: yAxis, | ||
| range: selection.range, | ||
| }); | ||
| const [searchQuery, setSearchQuery] = useQueryParamState({ | ||
| fieldName: 'attributeBreakdownsSearch', | ||
| }); | ||
| const sortingMethod: SortingMethod = 'rrr'; | ||
| const [page, setPage] = useState(0); | ||
| const theme = useTheme(); | ||
|
|
||
| // Debouncing the search query here to ensure smooth typing, by delaying the re-mounts a little as the user types. | ||
| // query here to ensure smooth typing, by delaying the re-mounts a little as the user types. | ||
| const debouncedSearchQuery = useDebouncedValue(searchQuery ?? '', 100); | ||
|
|
||
| const filteredRankedAttributes = useMemo(() => { | ||
| const attrs = data?.rankedAttributes; | ||
|
|
@@ -126,26 +128,28 @@ export function CohortComparison({ | |
| }; | ||
| }, [selection, yAxis]); | ||
|
|
||
| if (isError) { | ||
| return <LoadingError message={t('Failed to load attribute breakdowns')} />; | ||
| } | ||
|
|
||
| return ( | ||
| <Panel data-explore-chart-selection-region> | ||
| <Flex direction="column" gap="xl" padding="xl"> | ||
| <ControlsContainer> | ||
| <StyledBaseSearchBar | ||
| placeholder={t('Search keys')} | ||
| onChange={query => { | ||
| setSearchQuery(query); | ||
| }} | ||
| query={debouncedSearchQuery} | ||
| size="sm" | ||
| /> | ||
| <AttributeBreakdownsComponent.FeedbackButton /> | ||
| </ControlsContainer> | ||
| {isLoading ? ( | ||
| <AttributeBreakdownsComponent.LoadingCharts /> | ||
| ) : ( | ||
| <Fragment> | ||
| {selectionHint && ( | ||
| <SelectionHintContainer> | ||
| <SelectionHint color={theme.chart.getColorPalette(0)?.[0]}> | ||
|
|
@@ -211,7 +215,6 @@ const ControlsContainer = styled('div')` | |
| display: flex; | ||
| align-items: center; | ||
| gap: ${space(0.5)}; | ||
| `; | ||
|
|
||
| const StyledBaseSearchBar = styled(BaseSearchBar)` | ||
|
|
@@ -241,7 +244,6 @@ const SelectionHintContainer = styled('div')` | |
| display: flex; | ||
| flex-direction: column; | ||
| gap: ${space(0.5)}; | ||
| `; | ||
|
|
||
| const SelectionHint = styled(Text)<{color?: string}>` | ||
|
|
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Error rendering changed from wrapped to unwrapped
Error handling logic changed:
LoadingErrornow returns early withoutPanelandFlexwrappers that were present in the original implementation. Previously, errors displayed within the same container layout as normal content. This could cause visual inconsistency in how errors appear compared to the rest of the component layout and prior behavior.Additional Locations (1)
static/app/views/explore/components/attributeBreakdowns/cohortComparisonContent.tsx#L130-L133There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will be working on the error state next