fix(workflow-engine): Link cron monitor detectors to shadow alert workflows #103919
+67
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…kflows When creating a cron monitor with alert notifications via the old APIs, a "shadow" alert rule is created which generates a Workflow, but the DetectorWorkflow link between the cron Detector and the Workflow was not being created. Changes: - Modified IssueAlertMigrator._create_detector_lookups() to find cron detectors by extracting monitor.slug from rule conditions and querying for the associated detector via DataSource - Removed conditional check that was skipping _connect_default_detectors() for CRON_MONITOR rules, allowing detector linking to happen - Used in_test_hide_transaction_boundary() to safely query across databases Part of [NEW-593: Cron Monitor Alerts are not linked to monitor when created via the old flow](https://linear.app/getsentry/issue/NEW-593/cron-monitor-alerts-are-not-linked-to-monitor-when-created-via-the-old)
github-actions
bot
added
the
Scope: Backend
ceorourke
approved these changes
Nov 25, 2025
evanpurkhiser
deleted the
evanpurkhiser/fix-workflow-engine-link-cron-monitor-detectors-to-shadow-alert-workflows
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating a cron monitor with alert notifications via the old APIs,
a "shadow" alert rule is created which generates a Workflow, but the
DetectorWorkflow link between the cron Detector and the Workflow was
not being created.
Changes:
detectors by extracting monitor.slug from rule conditions and querying
for the associated detector via DataSource
for CRON_MONITOR rules, allowing detector linking to happen
Part of NEW-593: Cron Monitor Alerts are not linked to monitor when created via the old flow