Skip to content

Conversation

@isabellaenriquez
Copy link
Member

@isabellaenriquez isabellaenriquez commented Nov 28, 2025

Split out from #103983

Pt 5 of https://linear.app/getsentry/issue/BIL-1817/update-usage-overview-table-with-new-designs

Introduces the new panel (behind a non-existent FF) + fixes file structure so components are nested
Screenshot 2025-11-28 at 4 08 50 PM

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Nov 28, 2025
@isabellaenriquez isabellaenriquez marked this pull request as ready for review November 28, 2025 21:10
@isabellaenriquez isabellaenriquez requested a review from a team as a code owner November 28, 2025 21:10
Base automatically changed from isabella/uo-v2-pt-4 to master December 2, 2025 19:09
});

const formattedAdditionalReserved = null;
const formattedGifted = displayPriceWithCents({cents: reservedBudget.freeBudget});
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Gifted field displays zero values unnecessarily

The formattedGifted variable is always computed regardless of whether freeBudget or free is zero. Since displayPriceWithCents({cents: 0}) returns "$0.00" and formatReservedWithUnits(0, category) returns "0" (both truthy strings), the conditional {formattedGifted && ...} will render the "Gifted" field showing "$0.00" or "0" when there's actually no gifted amount. The tests explicitly set non-zero gifted values, suggesting this zero case wasn't intended to display. Compare this to formattedAdditionalReserved which correctly uses a conditional check before formatting.

Additional Locations (1)

Fix in Cursor Fix in Web

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was intentional however since this is not GA'd yet it's possible we will provide the same treatment as we do for additional reserved or vice versa later on

@isabellaenriquez isabellaenriquez merged commit 2a29687 into master Dec 2, 2025
47 of 48 checks passed
@isabellaenriquez isabellaenriquez deleted the isabella/uo-v2-pt-5 branch December 2, 2025 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants