fix(seer): Stop overriding codeReviewTriggers when bulk updating settings #104912
+18
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
![sentry[bot]](https://avatars.githubusercontent.com/u/1396951?s=60&v=4){kind=small}
Comment on lines
+17
to
27
| repositoryIds: string[]; | ||
| enabledCodeReview?: never; | ||
| } | ||
| | { | ||
| codeReviewTriggers: string[]; | ||
| enabledCodeReview: boolean; | ||
| repositoryIds: string[]; | ||
| }; | ||
|
|
||
| export function useBulkUpdateRepositorySettings( | ||
| options?: Omit< |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
srest2021
added a commit
that referenced
this pull request
Dec 15, 2025
followup: #104912 Previously we were requiring both `enabledCodeReview` and `codeReviewTriggers` when bulk updating. Here we allow either or both, and don't override if a field isn't present.
Member
|
@sentry review |
static/gsApp/views/seerAutomation/onboarding/hooks/useBulkUpdateRepositorySettings.tsx
Show resolved
Hide resolved
static/gsApp/views/seerAutomation/components/repoTable/seerRepoTableHeader.tsx
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #104908
Depends on #104918
Currently the backend expects that all fields will be passed to the bulk-edit endpoint, but that's only true in the wizard context, when we're creating everything for the first time: https://github.com/getsentry/sentry/blob/master/src/sentry/integrations/api/endpoints/organization_repository_settings.py#L16-L41
On the settings page people can bulk-update fields, one field at a time.