Skip to content

fix(seer): Stop overriding codeReviewTriggers when bulk updating settings #104912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ryan953 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(seer): Stop overriding codeReviewTriggers when bulk updating settings #104912

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions static/gsApp/views/seerAutomation/components/repoTable/seerRepoTableHeader.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,7 @@ import {addErrorMessage, addSuccessMessage} from 'sentry/actionCreators/indicato
import {DropdownMenu} from 'sentry/components/dropdownMenu';
import {SimpleTable} from 'sentry/components/tables/simpleTable';
import {t, tct, tn} from 'sentry/locale';
import {
DEFAULT_CODE_REVIEW_TRIGGERS,
type RepositoryWithSettings,
} from 'sentry/types/integrations';
import type {RepositoryWithSettings} from 'sentry/types/integrations';
import type {Sort} from 'sentry/utils/discover/fields';
import {useListItemCheckboxContext} from 'sentry/utils/list/useListItemCheckboxState';
import {parseQueryKey} from 'sentry/utils/queryClient';
Expand Down Expand Up @@ -51,8 +48,6 @@ export default function SeerRepoTableHeader({
selectedIds === 'all' ? repositories.map(repo => repo.id) : selectedIds;
mutateRepositorySettings(
{
// TODO: we should not be overriding the existing code review triggers for the repositories
codeReviewTriggers: DEFAULT_CODE_REVIEW_TRIGGERS,
enabledCodeReview,
repositoryIds,
},
Expand Down
27 changes: 17 additions & 10 deletions static/gsApp/views/seerAutomation/onboarding/hooks/useBulkUpdateRepositorySettings.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,22 @@ import {
} from 'sentry/utils/queryClient';
import useOrganization from 'sentry/utils/useOrganization';

interface RepositorySettings {
codeReviewTriggers: string[];
enabledCodeReview: boolean;
repositoryIds: string[];
}
type RepositorySettings =
| {
enabledCodeReview: boolean;
repositoryIds: string[];
codeReviewTriggers?: never;
}
| {
codeReviewTriggers: string[];
repositoryIds: string[];
enabledCodeReview?: never;
}
| {
codeReviewTriggers: string[];
enabledCodeReview: boolean;
repositoryIds: string[];
};

export function useBulkUpdateRepositorySettings(
options?: Omit<
Comment on lines +17 to 27

This comment was marked as outdated.

Sign in to view

Expand All @@ -25,11 +36,7 @@ export function useBulkUpdateRepositorySettings(
return fetchMutation<RepositoryWithSettings[]>({
method: 'PUT',
url: `/organizations/${organization.slug}/repos/settings/`,
data: {
codeReviewTriggers: data.codeReviewTriggers,
enabledCodeReview: data.enabledCodeReview,
repositoryIds: data.repositoryIds,
},
data,
});
},
...options,
Expand Down
Loading