Skip to content

Conversation

@malwilley
Copy link
Member

@malwilley malwilley commented Jan 8, 2026

In order to support the new designs which allow sorting for workflows that are either directly connected or connected via project detectors, we need some way to prioritize a certain detector ID.

This is a bit unconventional, but it adds support for /workflows/?priorityDetector=123 which will sort the list with workflows connected to detector 123 at the top.

@malwilley malwilley requested a review from a team as a code owner January 8, 2026 23:34
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jan 8, 2026
Copy link
Member

@wedamija wedamija left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this have a secondary sort? Everything below the priority detector will be arbitrary otherwise.

I think that the priority detector id should probably be a separate query param rather than embedded in the sort string

@wedamija
Copy link
Member

wedamija commented Jan 9, 2026

Should this have a secondary sort? Everything below the priority detector will be arbitrary otherwise.

I think that the priority detector id should probably be a separate query param rather than embedded in the sort string

Actually... should priority detector id just be a separate param, and if present, sort all of those workflows at the top. Then you can set the other sort as normal. That way you can say "give me detector 1 workflows as priority, and sort them by last triggered". and then all non-priority detectors also get sorted in that way, after the priority sort

@malwilley malwilley force-pushed the malwilley/feat/add-workflow-sort-by-priority-detector-id branch from 04ae6d4 to 3c5ec67 Compare January 9, 2026 17:09
@malwilley
Copy link
Member Author

@wedamija okay yeah I think I like it better with it as a separate query param since it is a bit wonky as a sort. Changed to add priorityDetector=<id>

@malwilley malwilley merged commit 8bf54e0 into master Jan 12, 2026
67 checks passed
@malwilley malwilley deleted the malwilley/feat/add-workflow-sort-by-priority-detector-id branch January 12, 2026 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants