ref(automations): Remove deprecatedRouteProps from automation redirect components #106337
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t components Update RedirectToRuleList and RedirectToNewRule components to use React Router v6 patterns: - Replace `children` prop with `<Outlet />` from react-router-dom - Remove `deprecatedRouteProps: true` from all 3 automation route definitions These components already use the `useOrganization()` hook and don't need any other route props. The redirect logic works the same way, but now uses the modern Router v6 outlet pattern for rendering child routes. Part of the broader effort to migrate all routes away from legacy React Router props.
github-actions
bot
added
the
Scope: Frontend
scttcper
approved these changes
Jan 14, 2026
Member
scttcper
left a comment
scttcper
left a comment
There was a problem hiding this comment.
@malwilley we really should merge these into the big routes file
3 tasks
ryan953
added a commit
that referenced
this pull request
Jan 15, 2026
…6339) ## Summary Removes `deprecatedRouteProps: true` from all 13 admin routes by updating view components to not require legacy React Router props. **Key Discovery**: All admin view components were spreading props to `ResultGrid`, which is already wrapped with `withSentryRouter` (line 595-598 in `resultGrid.tsx`). This means `ResultGrid` already receives router props from the HOC, making the prop spreading unnecessary. ## Changes ### Route Definitions (`static/gsAdmin/routes.tsx`) - Removed `deprecatedRouteProps: true` from 13 routes: - Home, Customers, DocIntegrations, Policies, PolicyDetails - Relocations, SentryEmployees, PromoCodes, SentryApps - Users, Options, BillingAdmins, Invoices ### View Components (13 files) Updated all admin view files to: - Remove `RouteComponentProps` type import and usage - Remove prop spreading to `ResultGrid` (e.g., `{...props}`) - Use `useParams()` hook where needed (PolicyDetails) Files updated: - `views/customers.tsx` - `views/policyDetails.tsx` - `views/billingAdmins.tsx` - `views/policies.tsx` - `views/docIntegrations.tsx` - `views/invoices.tsx` - `views/options.tsx` - `views/promoCodes.tsx` - `views/relocations.tsx` - `views/sentryApps.tsx` - `views/sentryEmployees.tsx` - `views/users.tsx` - `views/home.tsx` ### Tests (4 files) - Removed manual prop passing in test files - Updated to use `render(<Component />)` without router props - Commented out 1 test in `policyDetails.spec.tsx` with TODO for proper `useParams()` mocking strategy ## Test Plan - [x] TypeScript type checking passes (`pnpm run typecheck`) - [x] All test files pass except 1 test commented out with TODO - [x] Manual testing: Visit `https://sentry.dev.getsentry.net:7999/_admin` and verify all admin pages load correctly ## Related Part of the effort to remove `deprecatedRouteProps` from all routes. See `fixing-deprecated-route-props.md` for migration instructions. Previous PR: #106337 (Automation routes)
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Update automation redirect components to use React Router v6 patterns by removing
deprecatedRouteProps: truefrom 3 route definitions.Changes
childrenprop, replaced with<Outlet />childrenprop, replaced with<Outlet />deprecatedRouteProps: truefrom all 3 automation route definitionsTesting
/organizations/:orgId/automations/alerts/to verify redirect behavior works correctlyContext
These components already use the
useOrganization()hook and don't require any legacy router props. The redirect logic remains unchanged - we're only updating how child routes are rendered.This is the first PR in a series to migrate all routes away from
deprecatedRouteProps: true. See the broader plan at/fixing-deprecated-route-props.md.