Conversation
github-actions
bot
added
the
Scope: Frontend
scttcper
approved these changes
Jan 20, 2026
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| import {UptimeDetectorVerificationSection} from 'sentry/views/detectors/components/forms/uptime/verification'; | ||
|
|
||
| const ENVIRONMENT_CONFIG: React.ComponentProps<typeof DetectorBaseFields>['environment'] = | ||
| {includeAllEnvironments: false, fieldProps: {required: true}}; |
Contributor
There was a problem hiding this comment.
Empty required dropdown when project has no environments
Low Severity
When a project has no environments configured, the uptime detector form now shows an empty environment dropdown that is marked as required. Users cannot complete the form because there are no options to select. Previously, "All Environments" served as a fallback option. The combination of includeAllEnvironments: false with required: true creates an impossible-to-complete form state when environments is empty.
Additional Locations (1)
malwilley
deleted the
malwilley/fix/hide-all-environments-option-in-uptime-detector-form
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes ID-1235
Also does a small refactor of the props to allow better configuration of the environment field