fix(ui) Fix clipped descenders on project badge.#10687
Merged
Merged
Conversation
Add a smidgen more line-height to display clipped descenders.
Member
|
The alignment of settings headers gets a little worse after this :( |
Member
Author
|
@evanpurkhiser Are you referring to the badge/title placement changes? I thought having the badges shifted down 2px was nicer as the weight of the badge is more towards the center. |
jan-auer
added a commit
that referenced
this pull request
Nov 22, 2018
* master: feat: Initial pass on legacy message removal (#10713) fix: Crash when generating relay PII config (#10716) fix(gcs): Catch down transport errors for reconnects (#10726) feat: Add retry and timeout workaround for GCS failures (#10717) fix(snuba): Fix search pagination, remove old/unused in-memory scorin… (#10718) fix(features): Clean up auth provider component renderers (#10721) tests(ui): Wrap data forwarding with data-test-id (#10704) fix(snuba): Return empty results (rather than AssertionError) for out-of-range searches (#10719) fix(discover): move sidebar to the left, improve negative space, fix header vibrations (#10709) feat(discover): Result table responds to window size changes (#10692) feat(ui): beta badge (#10672) feat(forms): Allow entire forms to be disabled (#10707) feat(discover): Bump up max visible rows on table (#10702) fixed case in default repos where there are no repos. (#10706) fix(integrations): Azure DevOps check all users in outbound assignee sync. (#10667) fix(ui) Fix clipped descenders on project badge. (#10687) feat(jiraserver) Add OAuth connection process (#10685) fix(integrations) Include more context in logs when commit fetch fails (#10690)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a smidgen more line-height to display clipped descenders.
Before
After