feat(notifications): Add Size Analysis to notification settings UI by dashed · Pull Request #106940 · getsentry/sentry

dashed · 2026-01-25T14:22:19Z

closes https://linear.app/getsentry/issue/BIL-2007/add-size-analysis-to-notification-settings-ui-frontend

Summary

Enable the Size Analysis quota notification setting to appear in the user notification settings UI, gated behind the expose-category-size-analysis feature flag.

Set isBilledCategory: true for SIZE_ANALYSIS in DATA_CATEGORY_INFO
Add expose-category-size-analysis feature flag filtering in filterCategoryFields()
Gate quotaSizeAnalyses notification setting behind feature flag

Dependencies

Requires PR #106939 (BIL-1918) to be merged first

Test plan

Existing notification settings tests pass (18 tests)
Pre-commit checks pass
Manual verification that Size Analysis appears in notification settings only when feature flag is enabled

linear · 2026-01-25T14:22:22Z

BIL-2007 Add Size Analysis to notification settings UI (Frontend)

static/app/views/settings/account/notifications/notificationSettingsByType.tsx

- Set isBilledCategory: true for SIZE_ANALYSIS in DATA_CATEGORY_INFO - Add expose-category-size-analysis feature flag filtering in filterCategoryFields() - Gate quotaSizeAnalyses notification setting behind feature flag Closes BIL-2007

…tions Add the missing reservedSizeAnalyses property to all Reservations objects to fix TypeScript compilation errors in CI. This property was added to the Reservations type but was missing in several test files and implementation. Fixes: - productSelectionAvailability.spec.tsx - productUnavailableCTA.spec.tsx - usePreviewData.spec.tsx - useUpgradeNowParams.tsx

…ctations Update test expectations to include the reservedSizeAnalyses property that was added to the Reservations type in the implementation.

…frontend The backend notification setting used singular form `quotaSizeAnalysis` but the frontend DataCategory convention generates plural form `quotaSizeAnalyses`. This mismatch caused the Size Analysis notification setting to be non-functional. Changed backend from `quotaSizeAnalysis` to `quotaSizeAnalyses` to match the frontend convention and be consistent with similar settings like `quotaSeerUsers`.

…xture The am2Plans fixture returns sizeAnalyses with events: 100, so the test expectations should be 100, not undefined.

… RPC API The change from `quotaSizeAnalysis` to `quotaSizeAnalyses` was flagged as a breaking change by the openapi-diff CI check since the production RPC schema already contains the original value. Reverted to maintain backwards compatibility.

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.}

cursor · 2026-02-02T15:48:17Z

static/app/views/settings/account/notifications/notificationSettingsByType.tsx

      }
+      if (field.name.startsWith('quotaSizeAnalysis') && !includeSizeAnalysis) {
+        return false;
+      }


Feature flag filter uses wrong field name spelling

High Severity

The filter checks for field.name.startsWith('quotaSizeAnalysis') (singular spelling with 'i'), but the actual field name generated in fields2.tsx is quotaSizeAnalyses (plural spelling with 'e'). Since "analyses" doesn't start with "analysis" (they differ at the 'e' vs 'i'), this filter will never match. The Size Analysis notification setting will appear for all users regardless of the expose-category-size-analysis feature flag being enabled.

## Summary Fixes a bug introduced in PR #106940 where the Size Analysis notification setting was appearing for all users regardless of the `expose-category-size-analysis` feature flag. The issue was a typo in the feature flag filter: - Filter checked for `quotaSizeAnalysis` (singular, with 'i') - Actual field name is `quotaSizeAnalyses` (plural, with 'e') Since `'quotaSizeAnalyses'.startsWith('quotaSizeAnalysis')` returns `false`, the filter never matched. Simplified the filter to `quotaSize` to prevent similar typos in the future. ## Test plan - [x] Existing notification settings tests pass (13 tests) - [x] Pre-commit hooks pass

sentry · 2026-02-02T17:37:16Z

static/app/views/settings/account/notifications/notificationSettingsByType.tsx

+      if (field.name.startsWith('quotaSizeAnalysis') && !includeSizeAnalysis) {
+        return false;
+      }


Bug: The frontend generates the field name 'quotaSizeAnalyses' (plural) for the Size Analysis notification, but the backend expects 'quotaSizeAnalysis' (singular), causing save attempts to fail.
_{Severity: MEDIUM}

Suggested Fix

Align the frontend and backend field names. Either update the backend's NotificationSettingEnum in types.py to accept the plural form 'quotaSizeAnalyses', or change the frontend's field name generation in fields2.tsx to produce the singular form 'quotaSizeAnalysis'. Given the history, ensure the chosen fix does not break backward compatibility with the RPC API.

Prompt for AI Agent

Review the code at the location below. A potential bug has been identified by an AI agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not valid. Location: static/app/views/settings/account/notifications/notificationSettingsByType.tsx#L253-L255 Potential issue: There is a mismatch between the frontend and backend for the Size Analysis notification setting's field name. The frontend generates the field name as `'quotaSizeAnalyses'` based on the `plural` property of the data category. However, the backend's `NotificationSettingEnum` only recognizes the singular form, `'quotaSizeAnalysis'`. When a user attempts to save this setting, the frontend sends the pluralized name, which the backend's `validate_type()` function rejects, resulting in a validation error. This makes the Size Analysis notification setting visible but unsaveable in the UI.

…106940) closes https://linear.app/getsentry/issue/BIL-2007/add-size-analysis-to-notification-settings-ui-frontend ## Summary Enable the Size Analysis quota notification setting to appear in the user notification settings UI, gated behind the `expose-category-size-analysis` feature flag. - Set `isBilledCategory: true` for SIZE_ANALYSIS in `DATA_CATEGORY_INFO` - Add `expose-category-size-analysis` feature flag filtering in `filterCategoryFields()` - Gate `quotaSizeAnalyses` notification setting behind feature flag ## Dependencies - Requires [PR #106939](#106939) (BIL-1918) to be merged first ## Test plan - [x] Existing notification settings tests pass (18 tests) - [x] Pre-commit checks pass - [ ] Manual verification that Size Analysis appears in notification settings only when feature flag is enabled

## Summary Fixes a bug introduced in PR #106940 where the Size Analysis notification setting was appearing for all users regardless of the `expose-category-size-analysis` feature flag. The issue was a typo in the feature flag filter: - Filter checked for `quotaSizeAnalysis` (singular, with 'i') - Actual field name is `quotaSizeAnalyses` (plural, with 'e') Since `'quotaSizeAnalyses'.startsWith('quotaSizeAnalysis')` returns `false`, the filter never matched. Simplified the filter to `quotaSize` to prevent similar typos in the future. ## Test plan - [x] Existing notification settings tests pass (13 tests) - [x] Pre-commit hooks pass

github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Jan 25, 2026

vercel bot deployed to Preview January 25, 2026 14:24 View deployment

github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jan 26, 2026

dashed force-pushed the billing/BIL-2007 branch from cb142ff to 3d8a691 Compare January 26, 2026 21:42

dashed removed the Scope: Backend Automatically applied to PRs that change backend components label Jan 26, 2026

vercel bot deployed to Preview January 26, 2026 21:45 View deployment

getsentry deleted a comment from github-actions bot Jan 26, 2026

vercel bot deployed to Preview January 26, 2026 21:56 View deployment

dashed self-assigned this Jan 26, 2026

dashed marked this pull request as ready for review January 26, 2026 22:14

dashed requested a review from a team as a code owner January 26, 2026 22:14

dashed requested a review from a team January 26, 2026 22:14

sentry bot reviewed Jan 26, 2026

View reviewed changes

static/app/views/settings/account/notifications/notificationSettingsByType.tsx Outdated Show resolved Hide resolved

dashed force-pushed the billing/BIL-2007 branch from 332f050 to a5c10b0 Compare January 27, 2026 21:37

dashed requested a review from a team as a code owner January 27, 2026 21:37

github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jan 27, 2026

vercel bot deployed to Preview January 27, 2026 21:39 View deployment

vercel bot deployed to Preview January 27, 2026 21:47 View deployment

dashed force-pushed the billing/BIL-2007 branch from 25fe0ab to bfd96a1 Compare January 29, 2026 14:05

vercel bot deployed to Preview January 29, 2026 14:07 View deployment

brendanhsentry approved these changes Jan 29, 2026

View reviewed changes

dashed removed the Scope: Backend Automatically applied to PRs that change backend components label Feb 2, 2026

getsentry deleted a comment from github-actions bot Feb 2, 2026

dashed added 6 commits February 2, 2026 23:40

fix(tests): Add reservedSizeAnalyses to useUpgradeNowParams test expe…

d31ac9b

…ctations Update test expectations to include the reservedSizeAnalyses property that was added to the Reservations type in the implementation.

fix(tests): Update reservedSizeAnalyses test expectations to match fi…

fe83cf1

…xture The am2Plans fixture returns sizeAnalyses with events: 100, so the test expectations should be 100, not undefined.

dashed force-pushed the billing/BIL-2007 branch from bfd96a1 to 6fed872 Compare February 2, 2026 15:40

dashed enabled auto-merge (squash) February 2, 2026 15:41

vercel bot deployed to Preview February 2, 2026 15:43 View deployment

dashed merged commit 927d8a8 into master Feb 2, 2026
56 checks passed

dashed deleted the billing/BIL-2007 branch February 2, 2026 15:48

cursor bot reviewed Feb 2, 2026

View reviewed changes

dashed mentioned this pull request Feb 2, 2026

fix(notifications): Fix Size Analysis feature flag filter typo #107418

Merged

2 tasks

sentry bot reviewed Feb 2, 2026

View reviewed changes

sentry-release-bot bot mentioned this pull request Feb 17, 2026

publish: getsentry/sentry@26.2.0 getsentry/publish#7194

Closed

1 task

github-actions bot locked and limited conversation to collaborators Feb 18, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(notifications): Add Size Analysis to notification settings UI#106940

feat(notifications): Add Size Analysis to notification settings UI#106940
dashed merged 6 commits intomasterfrom
billing/BIL-2007

dashed commented Jan 25, 2026

Uh oh!

linear bot commented Jan 25, 2026

Uh oh!

Uh oh!

Uh oh!

cursor bot left a comment

Uh oh!

cursor bot Feb 2, 2026

Uh oh!

sentry bot Feb 2, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

dashed commented Jan 25, 2026

Summary

Dependencies

Test plan

Uh oh!

linear bot commented Jan 25, 2026

Uh oh!

Uh oh!

Uh oh!

cursor bot left a comment

Choose a reason for hiding this comment

Uh oh!

cursor bot Feb 2, 2026

Choose a reason for hiding this comment

Feature flag filter uses wrong field name spelling

Uh oh!

sentry bot Feb 2, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants