fix(notifications): Fix Size Analysis feature flag filter typo#107418
Merged
fix(notifications): Fix Size Analysis feature flag filter typo#107418
Conversation
The filter was checking for 'quotaSizeAnalysis' (singular) but the actual field name is 'quotaSizeAnalyses' (plural). This caused the filter to never match, allowing the Size Analysis notification setting to appear for all users regardless of the feature flag. Simplified the filter to 'quotaSize' to prevent similar typos.
github-actions
bot
added
the
Scope: Frontend
brendanhsentry
approved these changes
Feb 2, 2026
shellmayr
pushed a commit
that referenced
this pull request
Feb 4, 2026
## Summary Fixes a bug introduced in PR #106940 where the Size Analysis notification setting was appearing for all users regardless of the `expose-category-size-analysis` feature flag. The issue was a typo in the feature flag filter: - Filter checked for `quotaSizeAnalysis` (singular, with 'i') - Actual field name is `quotaSizeAnalyses` (plural, with 'e') Since `'quotaSizeAnalyses'.startsWith('quotaSizeAnalysis')` returns `false`, the filter never matched. Simplified the filter to `quotaSize` to prevent similar typos in the future. ## Test plan - [x] Existing notification settings tests pass (13 tests) - [x] Pre-commit hooks pass
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a bug introduced in PR #106940 where the Size Analysis notification setting was appearing for all users regardless of the
expose-category-size-analysisfeature flag.The issue was a typo in the feature flag filter:
quotaSizeAnalysis(singular, with 'i')quotaSizeAnalyses(plural, with 'e')Since
'quotaSizeAnalyses'.startsWith('quotaSizeAnalysis')returnsfalse, the filter never matched.Simplified the filter to
quotaSizeto prevent similar typos in the future.Test plan