fix(data-forwarding): Disable CTAs for users without org:write permission#107000
Merged
fix(data-forwarding): Disable CTAs for users without org:write permission#107000
Conversation
…sion The Access component was not properly gating buttons for users without org:write permission. Use the render prop pattern to check hasAccess and disable buttons with explanatory tooltips. Also rename the disabled prop to hasFeature for clearer semantics and adjust onboarding image styling.
github-actions
bot
added
the
Scope: Frontend
leeandher
commented
Jan 26, 2026
static/app/views/settings/organizationDataForwarding/components/dataForwarderOnboarding.tsx
Outdated
Show resolved
Hide resolved
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
malwilley
approved these changes
Jan 26, 2026
Member
malwilley
left a comment
malwilley
left a comment
There was a problem hiding this comment.
Looks good but agree that I'd prefer small functions with early returns rather than the nested ternaries
Member
Author
yeah on second thought i cant merge this like this, it looks horrendous -- will fix |
Move duplicate tooltip logic from onboarding and index components into a shared getCreateTooltip helper function in forms.tsx. This reduces duplication and ensures consistent messaging across the UI.
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
static/app/views/settings/organizationDataForwarding/util/forms.tsx
Outdated
Show resolved
Hide resolved
Show the feature unavailable message before the access denied message, since feature availability is a higher-level constraint than user permissions.
JonasBa
pushed a commit
that referenced
this pull request
Jan 27, 2026
…sion (#107000) access is a bit cleaner, image is constrained and rather than hide the button entirely, just disable it so users know they need more perms before: <img width="1211" height="652" alt="image" src="https://github.com/user-attachments/assets/d93736e5-92a0-428c-a0f1-428f93d85789" /> after: <img width="1156" height="487" alt="image" src="https://github.com/user-attachments/assets/c4f7402a-8eba-4607-ae0d-6d6f75ed5e33" />
priscilawebdev
pushed a commit
that referenced
this pull request
Feb 2, 2026
…sion (#107000) access is a bit cleaner, image is constrained and rather than hide the button entirely, just disable it so users know they need more perms before: <img width="1211" height="652" alt="image" src="https://github.com/user-attachments/assets/d93736e5-92a0-428c-a0f1-428f93d85789" /> after: <img width="1156" height="487" alt="image" src="https://github.com/user-attachments/assets/c4f7402a-8eba-4607-ae0d-6d6f75ed5e33" />
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
access is a bit cleaner, image is constrained and rather than hide the button entirely, just disable it so users know they need more perms
before:
after: