feat(aci): Add pagination and event ID links to open period list#107007
Merged
feat(aci): Add pagination and event ID links to open period list#107007
Conversation
malwilley
changed the title
github-actions
bot
added
the
Scope: Frontend
malwilley
commented
Jan 26, 2026
| /** | ||
| * Which type of pagination implementation is used by the API. | ||
| */ | ||
| paginatorType?: 'offset' | 'cursor'; |
Member
Author
There was a problem hiding this comment.
The pagination caption was wrong because the open period endpoint uses an offset paginator, but the events endpoint uses cursor pagination. Adding this allows us to support both.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
malwilley
force-pushed
the
malwilley/feat/add-event-id-links-in-open-period-list
branch
from
f7ca39d to
2809956
Compare
ceorourke
approved these changes
Jan 26, 2026
Member
ceorourke
left a comment
ceorourke
left a comment
There was a problem hiding this comment.
Looks good to my backend eyes, will not be offended if you re-request an FE reviewer
scttcper
approved these changes
Jan 27, 2026
malwilley
deleted the
malwilley/feat/add-event-id-links-in-open-period-list
branch
priscilawebdev
pushed a commit
that referenced
this pull request
Feb 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes ISWF-1929
Closes ISWF-1932
Before:
After: