ref(alerts): replace useRouter with specific hooks in alerts projectProvider#110067
ref(alerts): replace useRouter with specific hooks in alerts projectProvider#110067evanpurkhiser wants to merge 31 commits into
Conversation
…hboardFromFileModal
Moves the "Test Monitor" button to the Verification section header as a trailing item, and moves the "Suggest Assertions" button next to the "+ Add Assertion" button in the assertions field. Fixes [NEW-763](https://linear.app/getsentry/issue/NEW-763)
…riptions Fixes NEW-761
github-actions
Bot
added
Scope: Frontend
|
🚨 Warning: This pull request contains Frontend and Backend changes! It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently. Have questions? Please ask in the |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
| }, | ||
| }); | ||
| {replace: true} | ||
| ); |
There was a problem hiding this comment.
Replace navigations missing preventScrollReset option
Medium Severity
All browserHistory.replace(...) → navigate(..., {replace: true}) conversions are missing preventScrollReset: true. The browserHistory.replace shim explicitly adds preventScrollReset: true to replicate react-router 3 behavior (see comment in browserHistory.tsx). Without it, replace navigations may cause unwanted scroll resets. This affects multiple files, but is especially impactful in flamegraphQueryParamSync (fires on every state change) and traceWaterfall (fires on node click), where scroll jumping would be very disruptive.
Additional Locations (2)
|
This PR has a migration; here is the generated SQL for for --
-- Raw Python operation
--
-- THIS OPERATION CANNOT BE WRITTEN AS SQL |
|
Closing to recreate after rebasing onto master |
1 participant
Part of the React Router 6 cleanup — replaces
useRouter()with specific hooks (useNavigate,useLocation,useParams, etc.)See REACT_ROUTER_6_CLEANUP.md for full context.