Skip to content

fix(metrics): Enable Save as for multi-aggregate queries#110325

Merged
nsdeschenes merged 2 commits intomasterfrom
nd/logs-574/allow-multi-aggregate-save-as
Mar 13, 2026
Merged

fix(metrics): Enable Save as for multi-aggregate queries#110325
nsdeschenes merged 2 commits intomasterfrom
nd/logs-574/allow-multi-aggregate-save-as

Conversation

@nsdeschenes
Copy link
Contributor

@nsdeschenes nsdeschenes commented Mar 10, 2026

Summary

  • Remove the stale multi-aggregate early-access gate from MetricSaveAs so Save as is no longer disabled when a panel has multiple visualizes.
  • Drop the unsupported-state tooltip and disabled wiring for both the direct button path and dropdown trigger path.
  • Add metricSaveAs.spec.tsx coverage that verifies Save as remains enabled for multi-aggregate submenu items and still executes a single direct action item.

Refs LOGS-574

Made with Cursor

@linear-code
Copy link

linear-code bot commented Mar 10, 2026

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Mar 10, 2026
@nsdeschenes nsdeschenes marked this pull request as ready for review March 10, 2026 17:55
@nsdeschenes nsdeschenes requested a review from a team as a code owner March 10, 2026 17:55
Remove the early-access guard that disabled Save as when a metrics query
contains multiple visualizes. This allows users to save and continue using
multi-aggregate workflows now that dashboard conversion support exists.

Refs LOGS-574
Co-Authored-By: GPT-5 Codex <noreply@openai.com>

Made-with: Cursor
@nsdeschenes nsdeschenes force-pushed the nd/logs-574/allow-multi-aggregate-save-as branch from b3d9642 to d2ed523 Compare March 13, 2026 10:40
@nsdeschenes nsdeschenes merged commit 53c45e6 into master Mar 13, 2026
63 checks passed
@nsdeschenes nsdeschenes deleted the nd/logs-574/allow-multi-aggregate-save-as branch March 13, 2026 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants