fix(metrics): Enable Save as for multi-aggregate queries#110325
Merged
nsdeschenes merged 2 commits intomasterfrom Mar 13, 2026
Merged
fix(metrics): Enable Save as for multi-aggregate queries#110325nsdeschenes merged 2 commits intomasterfrom
nsdeschenes merged 2 commits intomasterfrom
Conversation
nikkikapadia
approved these changes
Mar 12, 2026
Remove the early-access guard that disabled Save as when a metrics query contains multiple visualizes. This allows users to save and continue using multi-aggregate workflows now that dashboard conversion support exists. Refs LOGS-574 Co-Authored-By: GPT-5 Codex <noreply@openai.com> Made-with: Cursor
b3d9642 to
d2ed523
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MetricSaveAsso Save as is no longer disabled when a panel has multiple visualizes.metricSaveAs.spec.tsxcoverage that verifies Save as remains enabled for multi-aggregate submenu items and still executes a single direct action item.Refs LOGS-574
Made with Cursor