Skip to content

fix(metrics): Enable Save as for multi-aggregate queries #110325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nsdeschenes merged 2 commits into from
Mar 13, 2026
Merged

fix(metrics): Enable Save as for multi-aggregate queries #110325

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c68b967
fix(metrics): Enable Save as for multi-aggregate queries
nsdeschenes Mar 10, 2026
d2ed523
:fire: Remove test added in by AI
nsdeschenes Mar 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
69 changes: 19 additions & 50 deletions static/app/views/explore/metrics/metricToolbar/metricSaveAs.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,27 +1,13 @@
import {Button} from '@sentry/scraps/button';
import {Tooltip} from '@sentry/scraps/tooltip';

import {DropdownMenu} from 'sentry/components/dropdownMenu';
import {t} from 'sentry/locale';
import {useChartInterval} from 'sentry/utils/useChartInterval';
import {useOrganization} from 'sentry/utils/useOrganization';
import {canUseMetricsMultiAggregateUI} from 'sentry/views/explore/metrics/metricsFlags';
import {useMultiMetricsQueryParams} from 'sentry/views/explore/metrics/multiMetricsQueryParams';
import {useSaveAsMetricItems} from 'sentry/views/explore/metrics/useSaveAsMetricItems';

export function MetricSaveAs() {
const [interval] = useChartInterval();
const items = useSaveAsMetricItems({interval});
const metricQueries = useMultiMetricsQueryParams();

const organization = useOrganization();
const hasMultiVisualize = canUseMetricsMultiAggregateUI(organization);

const hasMultiAggregate = metricQueries.some(
query => query.queryParams.visualizes.length > 1
);

const isMultiVisDisabled = hasMultiVisualize && hasMultiAggregate;

if (items.length === 0) {
return null;
Expand All @@ -30,46 +16,29 @@ export function MetricSaveAs() {
if (items.length === 1 && 'onAction' in items[0]! && !('children' in items[0])) {
const item = items[0];
return (
<Tooltip
disabled={!isMultiVisDisabled}
title={t('Saving multi-aggregate metrics is not supported during early access.')}
>
<Button size="sm" onClick={item.onAction} aria-label={item.textValue}>
{t('Save as')}…
</Button>
);
}

return (
<DropdownMenu
items={items}
trigger={triggerProps => (
<Button
{...triggerProps}
size="sm"
onClick={item.onAction}
aria-label={item.textValue}
disabled={isMultiVisDisabled}
aria-label={t('Save as')}
onClick={e => {
e.stopPropagation();
e.preventDefault();
triggerProps.onClick?.(e);
}}
>
{t('Save as')}…
</Button>
</Tooltip>
);
}

return (
<Tooltip
disabled={!isMultiVisDisabled}
title={t('Saving multi-aggregate metrics is not supported during early access.')}
>
<DropdownMenu
isDisabled={isMultiVisDisabled}
items={items}
trigger={triggerProps => (
<Button
{...triggerProps}
disabled={isMultiVisDisabled}
size="sm"
aria-label={t('Save as')}
onClick={e => {
e.stopPropagation();
e.preventDefault();
triggerProps.onClick?.(e);
}}
>
{t('Save as')}…
</Button>
)}
/>
</Tooltip>
)}
/>
);
}
Loading