ref(navigation) cleanup sidebar styled components#110459
Merged
Merged
Conversation
Replace SidebarWrapper, SidebarHeader, and CollapsedSecondaryWrapper styled components with Flex layout primitives from @sentry/scraps/layout. Extract framer-motion animation config into a standalone helper function. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Fix bottom/height being applied to mobile layout instead of sidebar layout. Remove unused css and styled imports. Restore user-select: none on the navigation container. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Fix useMemo using tourIsActive instead of isOpen for animation props - Restore aria-label="Primary Navigation" on sidebar nav element - Remove spurious right=0 from superuser Container - Restore align=center and z-index on UserOnlyNavigation Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
The primary nav element does not need an accessible label. Replace the aria-label with a data-test-id and update tests accordingly. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
github-actions
Bot
added
the
Scope: Frontend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Reverts the data-test-id change introduced in the previous commit. Restores aria-label="Primary Navigation" on the primary nav element and updates tests to use getByRole queries instead of getByTestId. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
malwilley
approved these changes
Mar 11, 2026
The mobile navigation overlay was using a plain Flex (div) instead of a
nav element, losing the navigation landmark for screen readers. Similarly,
the topbar was missing the header landmark. Restore these by adding as="nav"
and as="header" to match the old styled('nav') and styled('header') elements.
Co-Authored-By: Claude Sonnet 4 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the use of styled for primary nav and moves collapsible component into the secondary navigation components