fix(agents): Handle null modelId in agent monitoring page#110505
Merged
priscilawebdev merged 1 commit intomasterfrom Mar 12, 2026
Merged
fix(agents): Handle null modelId in agent monitoring page#110505priscilawebdev merged 1 commit intomasterfrom
priscilawebdev merged 1 commit intomasterfrom
Conversation
The ModelName component and getModelPlatform function assumed modelId was always a string, but span data can contain null values. This caused a TypeError crash when calling .toLowerCase() on null. Add null guards to both the render path and the platform lookup function, and update the type to reflect that modelId can be null. Co-Authored-By: Claude Opus 4.6 <noreply@example.com>
github-actions
bot
added
the
Scope: Frontend
jjbayer
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Handle null
modelIdin theModelNamecomponent andgetModelPlatformfunctionon the agent monitoring page.
The code assumed
modelIdwas always a string, but span data can contain actualnullvalues. When a nullmodelIdreachedgetModelPlatform, calling.toLowerCase()on it threw aTypeError, crashing the page via React'serror boundary.
Adds null guards to both the render path and the platform lookup, and updates
the type to
string | nullto reflect reality.