fix(widgets): Add error boundary to widget footer#110506
Draft
priscilawebdev wants to merge 1 commit intomasterfrom
Draft
fix(widgets): Add error boundary to widget footer#110506priscilawebdev wants to merge 1 commit intomasterfrom
priscilawebdev wants to merge 1 commit intomasterfrom
Conversation
gggritso
reviewed
Mar 12, 2026
Member
gggritso
left a comment
There was a problem hiding this comment.
Makes sense, thanks! Wondering about that Panel change, though! I was thinking that adding a <Container position="relative" (or whatever the syntax is) wrapper around WidgetError to accomplish the same thing might be better. Seems like composing the wrapper is cleaner than adding props to the element
priscilawebdev
added a commit
that referenced
this pull request
Mar 13, 2026
Wrap `ModelsTable` with `<ErrorBoundary mini>` on the agent models landing page so that rendering errors (e.g. null `modelId` hitting `.toLowerCase()`) are contained within the table instead of crashing the entire page. This follows the existing pattern of wrapping table consumers at the call site. The widget footer error boundary was added in #110506 but `ModelsTable` (a standalone `GridEditable` table) was unprotected.
f6bc70f to
47a3d82
Compare
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
47a3d82 to
417178f
Compare
417178f to
7591dd1
Compare
7591dd1 to
56b754b
Compare
Wrap the Footer slot content in an ErrorBoundary so a crashing footer component does not take down the entire widget. Remove absolute positioning from WidgetError so it uses flow layout by default. Callers that need absolute positioning (visualization slot, widgetFrame, score cards, insights, explore) now compose it via a Container wrapper instead. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
27511b7 to
ee0bd32
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Wrap the Widget component's Footer slot in an ErrorBoundary, matching the
existing pattern used for the Visualization slot.
Previously, errors in footer content (e.g. null data passed to rendering
components) would propagate up and crash the entire page. Now footer errors
are contained within the widget frame, showing a WidgetError message while
the rest of the widget (title, visualization) continues to render normally.
This came up from a crash on the agent monitoring page where a null
modelIdin the LLM Calls widget footer took down the whole page. The root cause null
check is in #110505 — this PR adds defense-in-depth so similar issues in any
widget footer won't crash the page.