feat(preprod): Add git metadata and artifact IDs as tags for size analysis issues

[mtopo27]

Summary

• Extend _artifact_to_tags() to emit artifact_id, commit_sha, branch, repo, base_sha, base_branch, pr_number as tags on size analysis issue events
• Add select_related("preprod_artifact__commit_comparison") to 4 queryset calls in the comparison task to avoid N+1 queries
• Add tests for the new tags (with and without commit_comparison)

Test plan

• pytest -svv --create-db tests/sentry/preprod/size_analysis/test_grouptype.py — all 23 tests pass
• pre-commit run --files on all modified files passes

[cursor]

Cursor Bugbot has reviewed your changes and found 2 potential issues.

Autofix Details

Bugbot Autofix prepared fixes for both issues found in the latest run.

• ✅ Fixed: Nullable head_ref used unconditionally as tag value
  • I guarded the branch tag assignment so head_ref is only added when non-null, preventing None values in the string tag map.
• ✅ Fixed: Missing select_related for commit_comparison in manual task
  • I added select_related("preprod_artifact__commit_comparison") to both manual comparison metric querysets to avoid per-artifact lazy loads.

Or push these changes by commenting:

@cursor push 067ecdfead

Preview (067ecdfead)

diff --git a/src/sentry/preprod/size_analysis/grouptype.py b/src/sentry/preprod/size_analysis/grouptype.py
--- a/src/sentry/preprod/size_analysis/grouptype.py
+++ b/src/sentry/preprod/size_analysis/grouptype.py
@@ -61,7 +61,8 @@
     commit_comparison = artifact.commit_comparison
     if commit_comparison is not None:
         tags["commit_sha"] = commit_comparison.head_sha
-        tags["branch"] = commit_comparison.head_ref
+        if commit_comparison.head_ref is not None:
+            tags["branch"] = commit_comparison.head_ref
         tags["repo"] = commit_comparison.head_repo_name
         if commit_comparison.base_sha:
             tags["base_sha"] = commit_comparison.base_sha

diff --git a/src/sentry/preprod/size_analysis/tasks.py b/src/sentry/preprod/size_analysis/tasks.py
--- a/src/sentry/preprod/size_analysis/tasks.py
+++ b/src/sentry/preprod/size_analysis/tasks.py
@@ -326,6 +326,7 @@
         )
         .select_related("preprod_artifact")
         .select_related("preprod_artifact__mobile_app_info")
+        .select_related("preprod_artifact__commit_comparison")
     )
     head_size_metrics = list(head_size_metrics_qs)
 
@@ -337,6 +338,7 @@
         )
         .select_related("preprod_artifact")
         .select_related("preprod_artifact__mobile_app_info")
+        .select_related("preprod_artifact__commit_comparison")
     )
     base_size_metrics = list(base_size_metrics_qs)

_{This Bugbot Autofix run was free. To enable autofix for future PRs, go to the Cursor dashboard.}

[github-actions]

Backend Test Failures

Failures on 81a465e in this run:

tests/sentry/preprod/size_analysis/test_size_analysis_tasks.py::ArtifactToTagsTest::test_minimal_artifact_data — log

tests/sentry/preprod/size_analysis/test_size_analysis_tasks.py:272: in test_minimal_artifact_data
    assert tags == {"app_id": "com.example.app"}
E   AssertionError: assert {'app_id': 'c...act_id': '39'} == {'app_id': 'com.example.app'}
E     
E     Omitting 1 identical items, use -vv to show
E     Left contains 1 more item:
E     {'artifact_id': '39'}
E     
E     Full diff:
E       {
E           'app_id': 'com.example.app',
E     +     'artifact_id': '39',
E       }

[cursor]

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

[github-actions]

Backend Test Failures

Failures on 50f543e in this run:

tests/sentry/preprod/size_analysis/test_size_analysis_tasks.py::ArtifactToTagsTest::test_minimal_artifact_data — log

tests/sentry/preprod/size_analysis/test_size_analysis_tasks.py:272: in test_minimal_artifact_data
    assert tags == {"app_id": "com.example.app"}
E   AssertionError: assert {'app_id': 'c...act_id': '39'} == {'app_id': 'com.example.app'}
E     
E     Omitting 1 identical items, use -vv to show
E     Left contains 1 more item:
E     {'artifact_id': '39'}
E     
E     Full diff:
E       {
E           'app_id': 'com.example.app',
E     +     'artifact_id': '39',
E       }

[chromy]

this get's called twice, once for head and once for base build:

You might want to add this below: https://github.com/getsentry/sentry/pull/110854/changes#diff-be91e49fb005a5e8d892931306474bc033bd1af21bb40c5a929f89562ea6742eR246

(so it appears at the root level)

[chromy]

oh I see it's controlled via the include_git boolean. I still would not put this here even if you want it nested under head. You could just directly add the tags below and name them head.foo

[chromy]

lgtm