ref(rr6): Remove useRouter from pageFilters actions#110888
Merged
evanpurkhiser merged 1 commit intomasterfrom Mar 25, 2026
Merged
Conversation
github-actions
bot
added
the
Scope: Frontend
evanpurkhiser
commented
Mar 17, 2026
Comment on lines
+176
to
+188
| const routerNavigate = router | ||
| ? (((to: any, options?: any) => { | ||
| if (typeof to === 'number') { | ||
| router.go(to); | ||
| return; | ||
| } | ||
| if (options?.replace) { | ||
| router.replace(to); | ||
| } else { | ||
| router.push(to); | ||
| } | ||
| }) as ReactRouter3Navigate) | ||
| : undefined; |
Member
Author
There was a problem hiding this comment.
not sure why it decided to do it like this 🤦
Member
Author
There was a problem hiding this comment.
OK I see, it's because it's a class component and it can't get navgiate from useNaviate.
I'm going to swap this over to using a withNavigate deprecated HoC that we can use in these few places, and then ofc remove when we convert these all to FCs in whatever future.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
evanpurkhiser
force-pushed
the
evanpurkhiser/ref-rr6-remove-userouter-from-pagefilters-actions
branch
from
aaf84e6 to
e39328f
Compare
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
There are 2 total unresolved issues (including 1 from previous review).
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
evanpurkhiser
force-pushed
the
evanpurkhiser/ref-rr6-remove-userouter-from-pagefilters-actions
branch
from
e39328f to
0a0bae5
Compare
evanpurkhiser
force-pushed
the
evanpurkhiser/ref-rr6-remove-userouter-from-pagefilters-actions
branch
from
0a0bae5 to
91c8e5e
Compare
scttcper
approved these changes
Mar 25, 2026
evanpurkhiser
force-pushed
the
evanpurkhiser/ref-rr6-remove-userouter-from-pagefilters-actions
branch
from
91c8e5e to
081ccab
Compare
evanpurkhiser
force-pushed
the
evanpurkhiser/ref-rr6-remove-userouter-from-pagefilters-actions
branch
from
351d90b to
22afef1
Compare
evanpurkhiser
force-pushed
the
evanpurkhiser/ref-rr6-remove-userouter-from-pagefilters-actions
branch
from
1c3f3ee to
d363e8e
Compare
Replace the `router` parameter with `location` + `navigate` in updateDateTime, updateProjects, updateEnvironments, and initializeUrlState. This removes the dependency on the legacy InjectedRouter type from all page filter action functions.
evanpurkhiser
force-pushed
the
evanpurkhiser/ref-rr6-remove-userouter-from-pagefilters-actions
branch
from
d363e8e to
226a790
Compare
evanpurkhiser
deleted the
evanpurkhiser/ref-rr6-remove-userouter-from-pagefilters-actions
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the
routerparameter withlocation+navigateinupdateDateTime, updateProjects, updateEnvironments, and
initializeUrlState. This removes the dependency on the legacy
InjectedRouter type from all page filter action functions.