ref(webvitals): Break circular import by moving ORDER constant to types#111487
Merged
evanpurkhiser merged 2 commits intomasterfrom Mar 25, 2026
Merged
ref(webvitals): Break circular import by moving ORDER constant to types#111487evanpurkhiser merged 2 commits intomasterfrom
evanpurkhiser merged 2 commits intomasterfrom
Conversation
Move the ORDER constant from performanceScoreChart.tsx to the shared types.tsx module. The constant was causing a circular import chain: withProject → projectContext → thirds → primaryNavigationContext → navigationTour → explore/utils → eventView → discover/utils → convertWidgetToBuilderStateParams → useWidgetBuilderState → datasetConfig/base → datasetConfig/spans → transformPerformanceScoreBreakdownSeries → performanceScoreChart → performanceScoreBreakdownChartWidget → insightsTimeSeriesWidget → chartActionDropdown → feature → withProject Moving ORDER to types.tsx (where WebVitals is already defined) breaks the cycle at the transformPerformanceScoreBreakdownSeries → performanceScoreChart link. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Update the relative import of ORDER to use the new types module location. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
github-actions
bot
added
the
Scope: Frontend
Contributor
|
This fixes the issue for me, thank you! |
evanpurkhiser
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaks a circular import chain by moving the
ORDERconstant fromperformanceScoreChart.tsxto the sharedtypes.tsxmodule (whereWebVitalsis already defined).The cycle
withProject→projectContextprojectContext→thirdsthirds→primaryNavigationContextprimaryNavigationContext→navigationTournavigationTour→explore/utilsexplore/utils→discover/eventViewdiscover/eventView→discover/utilsdiscover/utils→convertWidgetToBuilderStateParamsconvertWidgetToBuilderStateParams→useWidgetBuilderStateuseWidgetBuilderState→datasetConfig/basedatasetConfig/base→datasetConfig/spansdatasetConfig/spans→transformPerformanceScoreBreakdownSeriestransformPerformanceScoreBreakdownSeries→performanceScoreChart← broken hereperformanceScoreChart→performanceScoreBreakdownChartWidgetperformanceScoreBreakdownChartWidget→insightsTimeSeriesWidgetinsightsTimeSeriesWidget→chartActionDropdownchartActionDropdown→featurefeature→withProject🔄fixes a loading issue on
sentry devserver