chore(aci): All create monitor buttons should link to type selection#111801
Conversation
github-actions
Bot
added
the
Scope: Frontend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix prepared a fix for the issue found in the latest run.
- ✅ Fixed: Unused export
makeMonitorCreateSettingsPathnameafter removing its only consumer- Removed the unused
makeMonitorCreateSettingsPathnamefunction from pathnames.tsx since it had no remaining consumers after the PR removed its only import.
- Removed the unused
Or push these changes by commenting:
@cursor push fb4497098e
Preview (fb4497098e)
diff --git a/static/app/views/detectors/pathnames.tsx b/static/app/views/detectors/pathnames.tsx
--- a/static/app/views/detectors/pathnames.tsx
+++ b/static/app/views/detectors/pathnames.tsx
@@ -23,10 +23,6 @@
return normalizeUrl(`${makeMonitorBasePathname(orgSlug)}new/`);
};
-export const makeMonitorCreateSettingsPathname = (orgSlug: string) => {
- return normalizeUrl(`${makeMonitorBasePathname(orgSlug)}new/settings/`);
-};
-
export const makeMonitorEditPathname = (orgSlug: string, monitorId: string) => {
return normalizeUrl(`${makeMonitorBasePathname(orgSlug)}${monitorId}/edit/`);
};This Bugbot Autofix run was free. To enable autofix for future PRs, go to the Cursor dashboard.
malwilley
changed the title
| <SentryDocumentTitle title={TITLE}> | ||
| <WorkflowEngineListLayout | ||
| actions={<DetectorListActions detectorType="uptime_domain_failure" />} | ||
| actions={<DetectorListActions />} |
There was a problem hiding this comment.
not for this pr -- but how could we DRY up all these WorkflowEngineListLayout components? feels fairly repetitive and wonder if we could do something to simplify this (as we add more monitor types, it'll be more difficult to maintain)
There was a problem hiding this comment.
I don't think having a little boilerplate in each list view page is necessarily a bad thing, WorkflowEngineListLayout is already an attempt to DRY up the code. Each list page needs to be rendered in a separate component since they be customized (for example the uptime page here needs to wrap the content in a MonitorViewContext provider)
…111801) "Create Monitor" buttons should always link to the initial type selection page. We made this link to the actual form on the type-specific pages after user feedback, but we now believe that the original experience was more consistent and leads to less confusion overall.
2 participants
Closes ISWF-2215
"Create Monitor" buttons should always link to the initial type selection page. We made this link to the actual form on the type-specific pages after user feedback, but we now believe that the original experience was more consistent and leads to less confusion overall.