Skip to content

ref(cmdk) simplify types#111857

Merged
JonasBa merged 2 commits intomasterfrom
jb/ref/cmdk-type-simplification
Mar 31, 2026
Merged

ref(cmdk) simplify types#111857
JonasBa merged 2 commits intomasterfrom
jb/ref/cmdk-type-simplification

Conversation

@JonasBa
Copy link
Copy Markdown
Member

@JonasBa JonasBa commented Mar 30, 2026

The type field is unnecessary as we can already discriminate on the to, onAction and the presence of children

@JonasBa JonasBa requested a review from a team as a code owner March 30, 2026 22:27
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Mar 30, 2026
@JonasBa JonasBa requested a review from malwilley March 30, 2026 22:28
@JonasBa JonasBa merged commit 880f024 into master Mar 31, 2026
74 checks passed
@JonasBa JonasBa deleted the jb/ref/cmdk-type-simplification branch March 31, 2026 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants