Skip to content

fix(controlsilo) Don't include internal endpoints in controlsilourls#112166

Merged
markstory merged 2 commits into
masterfrom
chore-fix-controlsilo-url-gen
Apr 8, 2026
Merged

fix(controlsilo) Don't include internal endpoints in controlsilourls#112166
markstory merged 2 commits into
masterfrom
chore-fix-controlsilo-url-gen

Conversation

@markstory
Copy link
Copy Markdown
Member

We don't need to include internal only endpoints in the control silo URL mappings. I've added a internal_control_silo_endpoint decorator to cover this scenario as we didn't have enough metadata elsewhere.

We don't need to include internal only endpoints in the control silo URL
mappings. I've added a `internal_control_silo_endpoint` decorator to
cover this scenario as we didn't have enough metadata elsewhere.
@markstory markstory requested review from a team as code owners April 2, 2026 20:58
@markstory markstory requested a review from a team April 2, 2026 20:58
@github-actions github-actions Bot added Scope: Frontend Automatically applied to PRs that change frontend components Scope: Backend Automatically applied to PRs that change backend components labels Apr 2, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 2, 2026

🚨 Warning: This pull request contains Frontend and Backend changes!

It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently.

Have questions? Please ask in the #discuss-dev-infra channel.

Copy link
Copy Markdown
Contributor

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Comment thread src/sentry/api/base.py
@markstory markstory merged commit 37ea4b7 into master Apr 8, 2026
81 checks passed
@markstory markstory deleted the chore-fix-controlsilo-url-gen branch April 8, 2026 14:19
george-sentry pushed a commit that referenced this pull request Apr 9, 2026
…112166)

We don't need to include internal only endpoints in the control silo URL
mappings. I've added a `internal_control_silo_endpoint` decorator to
cover this scenario as we didn't have enough metadata elsewhere.
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 24, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Backend Automatically applied to PRs that change backend components Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants