Skip to content

fix(aci): Fix issue with manual cron monitor selected project#112602

Merged
malwilley merged 2 commits intomasterfrom
malwilley/fix-cron-monitor-form
Apr 9, 2026
Merged

fix(aci): Fix issue with manual cron monitor selected project#112602
malwilley merged 2 commits intomasterfrom
malwilley/fix-cron-monitor-form

Conversation

@malwilley
Copy link
Copy Markdown
Member

@malwilley malwilley commented Apr 9, 2026

#112484 caused a bug when creating cron monitors manually. The selected project will throw because the projectId is reset when the ProjectField gets rendered.

This is a quirk with the old form system, but all form fields need to be available on first render, otherwise they will reset form state when they come back in. This change makes sure that the form fields are rendered but hidden until you click "manually create monitor"

This does fix a hidden existing bug, which is that the initialData passed to the form was not actually being set for cron monitors.

@malwilley malwilley requested a review from a team as a code owner April 9, 2026 18:27
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Apr 9, 2026
Copy link
Copy Markdown
Contributor

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit e435ec5. Configure here.

Comment thread static/app/views/detectors/components/forms/cron/index.tsx
@malwilley malwilley merged commit 7bb9d5b into master Apr 9, 2026
66 checks passed
@malwilley malwilley deleted the malwilley/fix-cron-monitor-form branch April 9, 2026 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants