Skip to content

ref(tsc): open-period endpoint to apiOptions#113167

Merged
TkDodo merged 3 commits intomasterfrom
tkdodo/ref/open-periods-endpoint-to-apiOptions
Apr 16, 2026
Merged

ref(tsc): open-period endpoint to apiOptions#113167
TkDodo merged 3 commits intomasterfrom
tkdodo/ref/open-periods-endpoint-to-apiOptions

Conversation

@TkDodo
Copy link
Copy Markdown
Collaborator

@TkDodo TkDodo commented Apr 16, 2026

No description provided.

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Apr 16, 2026
Comment on lines +66 to +70
return useQuery({
...openPeriodsApiOptions({organization, limit: 1, ...params}),
enabled: defined(params.eventId) && defined(params.groupId),
select: ({json}) => json?.[0] ?? null,
});
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is beautiful and actually readable compared to before. It also fixes a (hidden) lint violation because spreading a query result ...query de-opts tracked queries!

@TkDodo TkDodo marked this pull request as ready for review April 16, 2026 14:38
@TkDodo TkDodo requested review from a team as code owners April 16, 2026 14:38
Copy link
Copy Markdown
Member

@malwilley malwilley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better, thank you!

@TkDodo TkDodo merged commit d1ca521 into master Apr 16, 2026
65 checks passed
@TkDodo TkDodo deleted the tkdodo/ref/open-periods-endpoint-to-apiOptions branch April 16, 2026 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants