ref(aci): Split connected detectors into projects and monitors lists#113205
Merged
ref(aci): Split connected detectors into projects and monitors lists#113205
Conversation
github-actions
bot
added
the
Scope: Frontend
saponifi3d
approved these changes
Apr 17, 2026
Contributor
saponifi3d
left a comment
saponifi3d
left a comment
There was a problem hiding this comment.
lgtm, i've been trying to think of ways to DRY up the two tables, but it seems like they're different enough to have two separate components.
| )} | ||
| > | ||
| <ErrorBoundary mini> | ||
| <ConnectedProjectsList automationId={automation.id} /> |
Contributor
There was a problem hiding this comment.
seems like we're mixing automation and workflow (ConnectedMonitorsList) - should we standardize to one term?
Member
Author
There was a problem hiding this comment.
Ugh yes the naming it's a bit messy, it might be worth doing a full rename to workflow everywhere on the frontend
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes ISWF-2471
ConnectedProjectsListcomponent which simply renders a list of ProjectBadgeworkflow:<workflow_id>instead of the list of IDsBefore:
After: