ref(pipeline): Remove now unused legacy integrationPipeline views#113328
ref(pipeline): Remove now unused legacy integrationPipeline views#113328evanpurkhiser wants to merge 1 commit intomasterfrom
Conversation
| */ | ||
| app: ['sentry/utils/statics-setup', 'sentry'], | ||
|
|
||
| /** | ||
| * Pipeline View for integrations | ||
| */ | ||
| pipeline: ['sentry/utils/statics-setup', 'sentry/views/integrationPipeline'], | ||
|
|
||
| // admin interface | ||
| gsAdmin: ['sentry/utils/statics-setup', path.join(staticPrefix, 'gsAdmin')], | ||
|
|
There was a problem hiding this comment.
Bug: The pipeline webpack entrypoint is removed, but the react_pipeline.html template still references the deleted entrypoints/pipeline.js asset, which will cause a KeyError in legacy integration views.
Severity: HIGH
Suggested Fix
Remove the legacy pipeline views and the react_pipeline.html template that depends on the deleted asset. Alternatively, restore the pipeline entrypoint in rspack.config.ts until all dependent integrations are fully migrated to the new API-driven approach and the old views are confirmed to be unused.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.
Location: rspack.config.ts#L255-L260
Potential issue: The removal of the `pipeline` webpack entrypoint in `rspack.config.ts`
prevents the `entrypoints/pipeline.js` bundle from being generated. However, legacy
pipeline views for AWS Lambda and GitHub integrations still render the
`react_pipeline.html` template, which attempts to load this deleted asset. In production
deployments that use a `frontend-versions.json` manifest, the asset lookup function
`get_frontend_app_asset_url` will fail to find the `pipeline.js` key. This will raise a
`KeyError` and cause a runtime crash for users in these legacy integration setup flows.
Also affects:
src/sentry/templates/sentry/bases/react_pipeline.html:17src/sentry/integrations/aws_lambda/integration.pysrc/sentry/integrations/github/integration.py
Did we get this right? 👍 / 👎 to inform future reviews.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 2925897. Configure here.
Removes all the supporting code for the "old-style" pipleine views that were rendered via a django template that rendered react (outside of the usual way the app boots) Should only be deployed once GitHub and AWS Lambda Integrations are 100% API driven. Refs [VDY-80: Remove legacy AWS Lambda integration setup views](https://linear.app/getsentry/issue/VDY-80/remove-legacy-aws-lambda-integration-setup-views) Refs [VDY-55: Remove legacy GitHub integration setup views](https://linear.app/getsentry/issue/VDY-55/remove-legacy-github-integration-setup-views)
2925897 to
7d7953b
Compare
| */ | ||
| app: ['sentry/utils/statics-setup', 'sentry'], | ||
|
|
||
| /** | ||
| * Pipeline View for integrations | ||
| */ | ||
| pipeline: ['sentry/utils/statics-setup', 'sentry/views/integrationPipeline'], | ||
|
|
||
| // admin interface | ||
| gsAdmin: ['sentry/utils/statics-setup', path.join(staticPrefix, 'gsAdmin')], | ||
|
|
There was a problem hiding this comment.
Bug: The pipeline webpack entrypoint is removed, but the react_pipeline.html template still references it. This will cause a KeyError when rendering legacy integration setup views.
Severity: CRITICAL
Suggested Fix
Remove the react_pipeline.html template and all backend code paths in the AWS Lambda and GitHub integrations that call render_react_view() to render it. This ensures the legacy, now-broken, frontend pipeline views are fully decommissioned and cannot be accessed.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.
Location: rspack.config.ts#L255-L260
Potential issue: The PR removes the `pipeline` webpack entrypoint from
`rspack.config.ts`. However, the backend template
`src/sentry/templates/sentry/bases/react_pipeline.html` still attempts to load the
corresponding asset (`entrypoints/pipeline.js`). In production, this will cause a
`KeyError` when the asset is not found in the manifest file. This template is rendered
by legacy integration pipeline views for AWS Lambda and GitHub. While the intention is
for these integrations to be fully API-driven, if any code path still triggers the old
views (e.g., due to incomplete rollout or misconfiguration), it will result in a server
error, breaking the integration setup flow for users.
Also affects:
src/sentry/integrations/aws_lambda/integration.pysrc/sentry/integrations/github/integration.pysrc/sentry/templates/sentry/bases/react_pipeline.html:17

Removes all the supporting code for the "old-style" pipleine views that
were rendered via a django template that rendered react (outside of the
usual way the app boots)
Should only be deployed once GitHub and AWS Lambda Integrations are 100%
API driven.
Refs VDY-80: Remove legacy AWS Lambda integration setup views
Refs VDY-55: Remove legacy GitHub integration setup views