Skip to content

fix: normalize issues and replays to info alerts with icons#113687

Merged
JoshuaKGoldberg merged 2 commits intomasterfrom
info-alerts-issues-and-replay-selection
Apr 23, 2026
Merged

fix: normalize issues and replays to info alerts with icons#113687
JoshuaKGoldberg merged 2 commits intomasterfrom
info-alerts-issues-and-replay-selection

Conversation

@JoshuaKGoldberg
Copy link
Copy Markdown
Member

@JoshuaKGoldberg JoshuaKGoldberg commented Apr 22, 2026

Turns out Issues was already using the design system component, Alert, after all. It's just manually setting showIcon={false}.

This switches both Issues and Replays to be left-aligned per Martha's note. It removes unnecessary flex wrapping too.

Area Before After
Issues image image
Replays image image

Fixes DE-1185.

@linear-code
Copy link
Copy Markdown

linear-code Bot commented Apr 22, 2026

@github-actions github-actions Bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Apr 22, 2026
@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as ready for review April 22, 2026 16:09
@JoshuaKGoldberg JoshuaKGoldberg requested review from a team as code owners April 22, 2026 16:09
@JoshuaKGoldberg JoshuaKGoldberg requested a review from a team April 22, 2026 16:09
Copy link
Copy Markdown
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better, thanks!

@JoshuaKGoldberg JoshuaKGoldberg merged commit 0426278 into master Apr 23, 2026
65 checks passed
@JoshuaKGoldberg JoshuaKGoldberg deleted the info-alerts-issues-and-replay-selection branch April 23, 2026 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants