Skip to content

ref(settings): migrate redeemPromoCode page to new form system#113789

Merged
TkDodo merged 7 commits intomasterfrom
tkdodo/ref/de-1192-migrate-redeem-promo-code-page
Apr 24, 2026
Merged

ref(settings): migrate redeemPromoCode page to new form system#113789
TkDodo merged 7 commits intomasterfrom
tkdodo/ref/de-1192-migrate-redeem-promo-code-page

Conversation

@TkDodo
Copy link
Copy Markdown
Collaborator

@TkDodo TkDodo commented Apr 23, 2026

No description provided.

@linear-code
Copy link
Copy Markdown

linear-code Bot commented Apr 23, 2026

@github-actions github-actions Bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Apr 23, 2026
Comment on lines +61 to +67
// non-field errors can be camelcase or snake case
const nonFieldErrors =
error.responseJSON?.non_field_errors || error.responseJSON?.nonFieldErrors;

if (Array.isArray(nonFieldErrors) && nonFieldErrors.length) {
addErrorMessage(nonFieldErrors[0], {duration: 10000});
}
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@evanpurkhiser I think this is what you hinted at in the last PR? We should somehow have this be respected everywhere, right ?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. This idea that they are camel or snake isn’t random though, that’s dependent on if the serualizer is a CamelCaseSerializer or not

@TkDodo TkDodo marked this pull request as ready for review April 23, 2026 13:14
@TkDodo TkDodo requested a review from a team as a code owner April 23, 2026 13:14
@TkDodo TkDodo requested a review from a team April 23, 2026 13:14
Comment thread static/gsApp/views/redeemPromoCode.tsx Outdated
Copy link
Copy Markdown
Contributor

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 007f26e. Configure here.

Comment thread static/gsApp/views/redeemPromoCode.tsx Outdated
@priscilawebdev
Copy link
Copy Markdown
Member

priscilawebdev commented Apr 24, 2026

image

Everything seems to be working well, but are we sure we want the primary button on the same row as the balance info?

Comment thread static/gsApp/views/redeemPromoCode.tsx Outdated
@TkDodo
Copy link
Copy Markdown
Collaborator Author

TkDodo commented Apr 24, 2026

Everything seems to be working well, but are we sure we want the primary button on the same row as the balance info?

This is how it’s in the current version too 🤷

TkDodo and others added 2 commits April 24, 2026 08:51
Co-authored-by: Priscila Oliveira <priscila.oliveira@sentry.io>
Copy link
Copy Markdown
Member

@priscilawebdev priscilawebdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@TkDodo TkDodo merged commit 8fbc247 into master Apr 24, 2026
65 checks passed
@TkDodo TkDodo deleted the tkdodo/ref/de-1192-migrate-redeem-promo-code-page branch April 24, 2026 08:06
@TkDodo TkDodo added the Trigger: Revert Add to a merged PR to revert it (skips CI) label Apr 24, 2026
@getsentry-bot
Copy link
Copy Markdown
Contributor

PR reverted: 9fcf3e3

getsentry-bot added a commit that referenced this pull request Apr 24, 2026
#113789)"

This reverts commit 8fbc247.

Co-authored-by: TkDodo <1021430+TkDodo@users.noreply.github.com>
@TkDodo TkDodo restored the tkdodo/ref/de-1192-migrate-redeem-promo-code-page branch April 24, 2026 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components Trigger: Revert Add to a merged PR to revert it (skips CI)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants