feat(preprod): Add app_info to snapshot response with prefetch#113960
Merged
NicoHinderling merged 2 commits intomasterfrom Apr 24, 2026
Merged
Conversation
github-actions
Bot
added
the
Scope: Backend
mtopo27
reviewed
Apr 24, 2026
| id=snapshot_id, project__organization_id=organization.id | ||
| artifact = ( | ||
| PreprodArtifact.objects.select_related("commit_comparison", "build_configuration") | ||
| .prefetch_related("mobile_app_info") |
Contributor
There was a problem hiding this comment.
what's "mobile_app_info" I thought we abstracted away everything to do with "mobile" bc snapshots can be anything?
mtopo27
approved these changes
Apr 24, 2026
Replace the nested app_info object on the snapshot response with a top-level app_id string. app_id is a column on PreprodArtifact, so we can drop the mobile_app_info prefetch and the build_configuration join that were added to populate the full BuildDetailsAppInfo payload. Co-Authored-By: Claude <noreply@anthropic.com>
This was referenced Apr 24, 2026
NicoHinderling
deleted the
04-24-feat_preprod_add_app_info_to_snapshot_response_with_prefetch
branch
NicoHinderling
added a commit
that referenced
this pull request
Apr 24, 2026
Groundwork for the snapshot viewer redesign: contract updates for `SnapshotDetailsApiResponse` and a simpler `getSnapshotPath` helper. - Add `app_id?: string | null` to match the backend addition in #113960. - Add `content_hash: string` to `SnapshotImage` so the frontend can dedupe or reference image bytes. - Drop `SidebarItemBase.badge` — unused after the sidebar rewrite that lands later in the stack. - Simplify `getSnapshotPath` to take only `{snapshotId}` (no org slug). The router handles org scoping for this route. Bottom of the 5-PR frontend stack for the snapshot viewer redesign. Backend counterpart is #113960.
NicoHinderling
added a commit
that referenced
this pull request
Apr 29, 2026
Redesigned snapshot header: single-row content plus the right-side actions dropdown. **`snapshotHeaderContent.tsx`** - Single wrapping flex row: title → project `IdBadge` → commit short-sha → PR number → branch → `IconCode` + monospace `app_id` (consumes the new field added in #113960 / #113955). - Drops the old multi-row header and the "Comparing: Head vs Base" pill row. The Head/Base toggle now lives in the content toolbar (handled by the redesign in #113958). **`snapshotHeaderActions.tsx`** - Right-side actions group: approval `Tag` + `AvatarList` of approvers + `...` dropdown. - Dropdown items: "Go to Base Build" (via `getSnapshotPath` from #113955, disabled when no base exists), "Rerun Status Checks", "Delete Snapshots", and an admin-only "Re-run comparison" entry for Sentry employees. - `ConfirmDelete` now requires typing `delete` rather than the opaque head artifact ID — safer UX for a destructive action. Top of the 5-PR frontend stack for the snapshot viewer redesign.
3 tasks
cleptric
pushed a commit
that referenced
this pull request
May 5, 2026
Redesigned snapshot header: single-row content plus the right-side actions dropdown. **`snapshotHeaderContent.tsx`** - Single wrapping flex row: title → project `IdBadge` → commit short-sha → PR number → branch → `IconCode` + monospace `app_id` (consumes the new field added in #113960 / #113955). - Drops the old multi-row header and the "Comparing: Head vs Base" pill row. The Head/Base toggle now lives in the content toolbar (handled by the redesign in #113958). **`snapshotHeaderActions.tsx`** - Right-side actions group: approval `Tag` + `AvatarList` of approvers + `...` dropdown. - Dropdown items: "Go to Base Build" (via `getSnapshotPath` from #113955, disabled when no base exists), "Rerun Status Checks", "Delete Snapshots", and an admin-only "Re-run comparison" entry for Sentry employees. - `ConfirmDelete` now requires typing `delete` rather than the opaque head artifact ID — safer UX for a destructive action. Top of the 5-PR frontend stack for the snapshot viewer redesign.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expose the artifact's
app_idon the snapshot details response.The frontend snapshot viewer needs this to display app identifier context in the header alongside commit and PR info.
app_idis already onPreprodArtifact, so this is just a passthrough — no extra queries, no new serializer.Ships independently alongside a 6-PR frontend stack for the snapshot viewer redesign — frontend and backend don't deploy atomically.