feat(preprod): Add snapshot types and path helper#113955
Merged
NicoHinderling merged 3 commits intomasterfrom Apr 24, 2026
Merged
feat(preprod): Add snapshot types and path helper#113955NicoHinderling merged 3 commits intomasterfrom
NicoHinderling merged 3 commits intomasterfrom
Conversation
Contributor
Author
This was referenced Apr 24, 2026
github-actions
Bot
added
the
Scope: Frontend
NicoHinderling
commented
Apr 24, 2026
| snapshotId: string; | ||
| }): string { | ||
| const {organizationSlug, snapshotId} = params; | ||
| return `/organizations/${organizationSlug}/preprod/snapshots/${snapshotId}/`; |
Contributor
Author
There was a problem hiding this comment.
i'm pretty sure we don't need to include the org slug, hence why im removing it. cleaner URLs
Contributor
Author
There was a problem hiding this comment.
nevermind, there's a caveat for self hosted i guess lol
have to leave this in
NicoHinderling
commented
Apr 24, 2026
| height: number; | ||
| key: string; | ||
| width: number; | ||
| content_hash?: string | null; |
Contributor
Author
There was a problem hiding this comment.
this field is already provided by the backend , we just didnt formally type it on the FE
NicoHinderling
force-pushed
the
04-24-feat_preprod_add_snapshot_types_and_path_helper
branch
from
8dbc16a to
5ac4232
Compare
mtopo27
approved these changes
Apr 24, 2026
mtopo27
approved these changes
Apr 24, 2026
NicoHinderling
force-pushed
the
04-24-feat_preprod_add_snapshot_types_and_path_helper
branch
from
5ac4232 to
14a6040
Compare
NicoHinderling
changed the base branch from
graphite-base/113955
to
04-24-ref_preprod_remove_hash_keyed_manifest_fallback
NicoHinderling
commented
Apr 24, 2026
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Base automatically changed from
04-24-ref_preprod_remove_hash_keyed_manifest_fallback
to
master
April 24, 2026 19:56
NicoHinderling
force-pushed
the
04-24-feat_preprod_add_snapshot_types_and_path_helper
branch
from
14a6040 to
faa7586
Compare
The prior path was a bare /preprod/snapshots/:id/. That route is only registered on customer domains (via withOrgPath), so rows that link through the helper 404 on localhost and single-tenant deploys. Prefix with /organizations/:slug/ so the scraps Link's normalizeUrl can strip it on customer domains — matching getBaseBuildPath and getCompareBuildPath.
The backend model stores app_id with a default of None; match that on the frontend type so consumers handle the missing-field case.
NicoHinderling
force-pushed
the
04-24-feat_preprod_add_snapshot_types_and_path_helper
branch
from
f4a7a8c to
550de20
Compare
NicoHinderling
deleted the
04-24-feat_preprod_add_snapshot_types_and_path_helper
branch
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 550de20. Configure here.
NicoHinderling
added a commit
that referenced
this pull request
Apr 29, 2026
Redesigned snapshot header: single-row content plus the right-side actions dropdown. **`snapshotHeaderContent.tsx`** - Single wrapping flex row: title → project `IdBadge` → commit short-sha → PR number → branch → `IconCode` + monospace `app_id` (consumes the new field added in #113960 / #113955). - Drops the old multi-row header and the "Comparing: Head vs Base" pill row. The Head/Base toggle now lives in the content toolbar (handled by the redesign in #113958). **`snapshotHeaderActions.tsx`** - Right-side actions group: approval `Tag` + `AvatarList` of approvers + `...` dropdown. - Dropdown items: "Go to Base Build" (via `getSnapshotPath` from #113955, disabled when no base exists), "Rerun Status Checks", "Delete Snapshots", and an admin-only "Re-run comparison" entry for Sentry employees. - `ConfirmDelete` now requires typing `delete` rather than the opaque head artifact ID — safer UX for a destructive action. Top of the 5-PR frontend stack for the snapshot viewer redesign.
3 tasks
cleptric
pushed a commit
that referenced
this pull request
May 5, 2026
Redesigned snapshot header: single-row content plus the right-side actions dropdown. **`snapshotHeaderContent.tsx`** - Single wrapping flex row: title → project `IdBadge` → commit short-sha → PR number → branch → `IconCode` + monospace `app_id` (consumes the new field added in #113960 / #113955). - Drops the old multi-row header and the "Comparing: Head vs Base" pill row. The Head/Base toggle now lives in the content toolbar (handled by the redesign in #113958). **`snapshotHeaderActions.tsx`** - Right-side actions group: approval `Tag` + `AvatarList` of approvers + `...` dropdown. - Dropdown items: "Go to Base Build" (via `getSnapshotPath` from #113955, disabled when no base exists), "Rerun Status Checks", "Delete Snapshots", and an admin-only "Re-run comparison" entry for Sentry employees. - `ConfirmDelete` now requires typing `delete` rather than the opaque head artifact ID — safer UX for a destructive action. Top of the 5-PR frontend stack for the snapshot viewer redesign.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Groundwork for the snapshot viewer redesign: contract updates for
SnapshotDetailsApiResponseand a simplergetSnapshotPathhelper.app_id?: string | nullto match the backend addition in feat(preprod): Add app_info to snapshot response with prefetch #113960.content_hash: stringtoSnapshotImageso the frontend can dedupe or reference image bytes.SidebarItemBase.badge— unused after the sidebar rewrite that lands later in the stack.Bottom of the 5-PR frontend stack for the snapshot viewer redesign. Backend counterpart is #113960.