ref(preprod): Drop hash-keyed manifest fallback by NicoHinderling · Pull Request #113967 · getsentry/sentry

NicoHinderling · 2026-04-24T18:18:18Z

Resolves the EME-977 TODO: drop the backwards-compat fallback for snapshot manifests that pre-date the content_hash field.

ImageMetadata.content_hash becomes required (str). Manifests from old SDK versions omitted it and relied on a content_hash or key fallback at every read site; all callers now assume the hash is present.

Drops the fallback and the EME-977 TODO at three sites:

preprod_artifact_snapshot.py — GET response construction.
tasks.py — head_by_name / base_by_name for diff matching.
tasks.py — head_meta_by_hash / base_meta_by_hash for rename detection.

No behavior change for any manifest uploaded by a modern client. If a legacy manifest without content_hash is still reachable, snapshot parsing will now raise a pydantic validation error instead of silently keying on the file name.

github-actions · 2026-04-24T18:25:04Z

Backend Test Failures

Failures on 4db2eda in this run:

tests/sentry/preprod/api/endpoints/test_preprod_artifact_snapshot.py::ProjectPreprodSnapshotTest::test_all_image_file_names_must_contain_all_images

— log

[gw0] linux -- Python 3.13.1 /home/runner/work/sentry/sentry/.venv/bin/python3
tests/sentry/preprod/api/endpoints/test_preprod_artifact_snapshot.py:287: in test_all_image_file_names_must_contain_all_images
    assert "all_image_file_names" in response.data["detail"]
E   AssertionError: assert 'all_image_file_names' in 'The images field is required and must be an object mapping image names to image metadata.'

tests/sentry/preprod/api/endpoints/test_preprod_artifact_snapshot.py::ProjectPreprodSnapshotTest::test_all_image_file_names_requires_selective

— log

[gw0] linux -- Python 3.13.1 /home/runner/work/sentry/sentry/.venv/bin/python3
tests/sentry/preprod/api/endpoints/test_preprod_artifact_snapshot.py:292: in test_all_image_file_names_requires_selective
    assert "selective" in response.data["detail"]
E   AssertionError: assert 'selective' in 'The images field is required and must be an object mapping image names to image metadata.'

tests/sentry/preprod/api/endpoints/test_preprod_artifact_snapshot.py::ProjectPreprodSnapshotTest::test_base_upload_triggers_comparison_for_waiting_head

— log

[gw0] linux -- Python 3.13.1 /home/runner/work/sentry/sentry/.venv/bin/python3
tests/sentry/preprod/api/endpoints/test_preprod_artifact_snapshot.py:365: in test_base_upload_triggers_comparison_for_waiting_head
    assert response.status_code == 200
E   assert 400 == 200
E    +  where 400 = <Response status_code=400, "application/json">.status_code

tests/sentry/preprod/api/endpoints/test_preprod_artifact_snapshot.py::ProjectPreprodSnapshotTest::test_selective_with_all_image_file_names_accepted

— log

[gw0] linux -- Python 3.13.1 /home/runner/work/sentry/sentry/.venv/bin/python3
tests/sentry/preprod/api/endpoints/test_preprod_artifact_snapshot.py:303: in test_selective_with_all_image_file_names_accepted
    assert response.status_code == 200
E   assert 400 == 200
E    +  where 400 = <Response status_code=400, "application/json">.status_code

tests/sentry/preprod/api/endpoints/test_preprod_artifact_snapshot.py::ProjectPreprodSnapshotTest::test_selective_without_all_image_file_names_accepted

— log

[gw0] linux -- Python 3.13.1 /home/runner/work/sentry/sentry/.venv/bin/python3
tests/sentry/preprod/api/endpoints/test_preprod_artifact_snapshot.py:299: in test_selective_without_all_image_file_names_accepted
    assert response.status_code == 200
E   assert 400 == 200
E    +  where 400 = <Response status_code=400, "application/json">.status_code

tests/sentry/preprod/api/endpoints/test_preprod_artifact_snapshot.py::ProjectPreprodSnapshotTest::test_snapshot_upload_creates_commit_comparison

— log

[gw0] linux -- Python 3.13.1 /home/runner/work/sentry/sentry/.venv/bin/python3
tests/sentry/preprod/api/endpoints/test_preprod_artifact_snapshot.py:87: in test_snapshot_upload_creates_commit_comparison
    assert response.status_code == 200
E   assert 400 == 200
E    +  where 400 = <Response status_code=400, "application/json">.status_code

tests/sentry/preprod/api/endpoints/test_preprod_artifact_snapshot.py::ProjectPreprodSnapshotTest::test_snapshot_upload_stores_manifest_key

— log

[gw0] linux -- Python 3.13.1 /home/runner/work/sentry/sentry/.venv/bin/python3
tests/sentry/preprod/api/endpoints/test_preprod_artifact_snapshot.py:116: in test_snapshot_upload_stores_manifest_key
    assert response.status_code == 200
E   assert 400 == 200
E    +  where 400 = <Response status_code=400, "application/json">.status_code

tests/sentry/preprod/api/endpoints/test_preprod_artifact_snapshot.py::ProjectPreprodSnapshotTest::test_successful_snapshot_upload

— log

[gw0] linux -- Python 3.13.1 /home/runner/work/sentry/sentry/.venv/bin/python3
tests/sentry/preprod/api/endpoints/test_preprod_artifact_snapshot.py:49: in test_successful_snapshot_upload
    assert response.status_code == 200
E   assert 400 == 200
E    +  where 400 = <Response status_code=400, "application/json">.status_code

tests/sentry/preprod/api/endpoints/test_preprod_artifact_snapshot.py::ProjectPreprodSnapshotGetTest::test_get_snapshot_details

— log

[gw0] linux -- Python 3.13.1 /home/runner/work/sentry/sentry/.venv/bin/python3
tests/sentry/preprod/api/endpoints/test_preprod_artifact_snapshot.py:450: in test_get_snapshot_details
    assert response.status_code == 200
E   assert 500 == 200
E    +  where 500 = <Response status_code=500, "application/json">.status_code

tests/sentry/preprod/api/endpoints/test_preprod_artifact_snapshot.py::ProjectPreprodSnapshotGetTest::test_get_snapshot_details_returns_all_images

— log

[gw0] linux -- Python 3.13.1 /home/runner/work/sentry/sentry/.venv/bin/python3
tests/sentry/preprod/api/endpoints/test_preprod_artifact_snapshot.py:507: in test_get_snapshot_details_returns_all_images
    assert response.status_code == 200
E   assert 500 == 200
E    +  where 500 = <Response status_code=500, "application/json">.status_code

tests/sentry/preprod/api/endpoints/test_preprod_artifact_snapshot.py::ProjectPreprodSnapshotGetTest::test_get_snapshot_details_with_vcs_info

— log

[gw0] linux -- Python 3.13.1 /home/runner/work/sentry/sentry/.venv/bin/python3
tests/sentry/preprod/api/endpoints/test_preprod_artifact_snapshot.py:480: in test_get_snapshot_details_with_vcs_info
    assert response.status_code == 200
E   assert 500 == 200
E    +  where 500 = <Response status_code=500, "application/json">.status_code

NicoHinderling · 2026-04-24T18:36:58Z

This stack of pull requests is managed by Graphite. Learn more about stacking.

github-actions · 2026-04-24T18:43:18Z

Backend Test Failures

Failures on 273eedd in this run:

tests/sentry/preprod/api/endpoints/test_preprod_artifact_snapshot.py::ProjectPreprodSnapshotTest::test_all_image_file_names_must_contain_all_images

— log

[gw0] linux -- Python 3.13.1 /home/runner/work/sentry/sentry/.venv/bin/python3
tests/sentry/preprod/api/endpoints/test_preprod_artifact_snapshot.py:287: in test_all_image_file_names_must_contain_all_images
    assert "all_image_file_names" in response.data["detail"]
E   AssertionError: assert 'all_image_file_names' in 'The images field is required and must be an object mapping image names to image metadata.'

tests/sentry/preprod/api/endpoints/test_preprod_artifact_snapshot.py::ProjectPreprodSnapshotTest::test_all_image_file_names_requires_selective

— log

[gw0] linux -- Python 3.13.1 /home/runner/work/sentry/sentry/.venv/bin/python3
tests/sentry/preprod/api/endpoints/test_preprod_artifact_snapshot.py:292: in test_all_image_file_names_requires_selective
    assert "selective" in response.data["detail"]
E   AssertionError: assert 'selective' in 'The images field is required and must be an object mapping image names to image metadata.'

tests/sentry/preprod/api/endpoints/test_preprod_artifact_snapshot.py::ProjectPreprodSnapshotTest::test_base_upload_triggers_comparison_for_waiting_head

— log

[gw0] linux -- Python 3.13.1 /home/runner/work/sentry/sentry/.venv/bin/python3
tests/sentry/preprod/api/endpoints/test_preprod_artifact_snapshot.py:365: in test_base_upload_triggers_comparison_for_waiting_head
    assert response.status_code == 200
E   assert 400 == 200
E    +  where 400 = <Response status_code=400, "application/json">.status_code

tests/sentry/preprod/api/endpoints/test_preprod_artifact_snapshot.py::ProjectPreprodSnapshotTest::test_selective_with_all_image_file_names_accepted

— log

[gw0] linux -- Python 3.13.1 /home/runner/work/sentry/sentry/.venv/bin/python3
tests/sentry/preprod/api/endpoints/test_preprod_artifact_snapshot.py:303: in test_selective_with_all_image_file_names_accepted
    assert response.status_code == 200
E   assert 400 == 200
E    +  where 400 = <Response status_code=400, "application/json">.status_code

tests/sentry/preprod/api/endpoints/test_preprod_artifact_snapshot.py::ProjectPreprodSnapshotTest::test_selective_without_all_image_file_names_accepted

— log

[gw0] linux -- Python 3.13.1 /home/runner/work/sentry/sentry/.venv/bin/python3
tests/sentry/preprod/api/endpoints/test_preprod_artifact_snapshot.py:299: in test_selective_without_all_image_file_names_accepted
    assert response.status_code == 200
E   assert 400 == 200
E    +  where 400 = <Response status_code=400, "application/json">.status_code

tests/sentry/preprod/api/endpoints/test_preprod_artifact_snapshot.py::ProjectPreprodSnapshotTest::test_snapshot_upload_creates_commit_comparison

— log

[gw0] linux -- Python 3.13.1 /home/runner/work/sentry/sentry/.venv/bin/python3
tests/sentry/preprod/api/endpoints/test_preprod_artifact_snapshot.py:87: in test_snapshot_upload_creates_commit_comparison
    assert response.status_code == 200
E   assert 400 == 200
E    +  where 400 = <Response status_code=400, "application/json">.status_code

tests/sentry/preprod/api/endpoints/test_preprod_artifact_snapshot.py::ProjectPreprodSnapshotTest::test_snapshot_upload_stores_manifest_key

— log

[gw0] linux -- Python 3.13.1 /home/runner/work/sentry/sentry/.venv/bin/python3
tests/sentry/preprod/api/endpoints/test_preprod_artifact_snapshot.py:116: in test_snapshot_upload_stores_manifest_key
    assert response.status_code == 200
E   assert 400 == 200
E    +  where 400 = <Response status_code=400, "application/json">.status_code

tests/sentry/preprod/api/endpoints/test_preprod_artifact_snapshot.py::ProjectPreprodSnapshotTest::test_successful_snapshot_upload

— log

[gw0] linux -- Python 3.13.1 /home/runner/work/sentry/sentry/.venv/bin/python3
tests/sentry/preprod/api/endpoints/test_preprod_artifact_snapshot.py:49: in test_successful_snapshot_upload
    assert response.status_code == 200
E   assert 400 == 200
E    +  where 400 = <Response status_code=400, "application/json">.status_code

tests/sentry/preprod/api/endpoints/test_preprod_artifact_snapshot.py::ProjectPreprodSnapshotGetTest::test_get_snapshot_details

— log

[gw0] linux -- Python 3.13.1 /home/runner/work/sentry/sentry/.venv/bin/python3
tests/sentry/preprod/api/endpoints/test_preprod_artifact_snapshot.py:450: in test_get_snapshot_details
    assert response.status_code == 200
E   assert 500 == 200
E    +  where 500 = <Response status_code=500, "application/json">.status_code

tests/sentry/preprod/api/endpoints/test_preprod_artifact_snapshot.py::ProjectPreprodSnapshotGetTest::test_get_snapshot_details_returns_all_images

— log

[gw0] linux -- Python 3.13.1 /home/runner/work/sentry/sentry/.venv/bin/python3
tests/sentry/preprod/api/endpoints/test_preprod_artifact_snapshot.py:507: in test_get_snapshot_details_returns_all_images
    assert response.status_code == 200
E   assert 500 == 200
E    +  where 500 = <Response status_code=500, "application/json">.status_code

tests/sentry/preprod/api/endpoints/test_preprod_artifact_snapshot.py::ProjectPreprodSnapshotGetTest::test_get_snapshot_details_with_vcs_info

— log

[gw0] linux -- Python 3.13.1 /home/runner/work/sentry/sentry/.venv/bin/python3
tests/sentry/preprod/api/endpoints/test_preprod_artifact_snapshot.py:480: in test_get_snapshot_details_with_vcs_info
    assert response.status_code == 200
E   assert 500 == 200
E    +  where 500 = <Response status_code=500, "application/json">.status_code

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit da81756. Configure here.}

github-actions Bot added the Scope: Backend Automatically applied to PRs that change backend components label Apr 24, 2026

NicoHinderling marked this pull request as ready for review April 24, 2026 18:18

NicoHinderling requested a review from a team as a code owner April 24, 2026 18:18

mtopo27 approved these changes Apr 24, 2026

View reviewed changes

vercel Bot deployed to Preview April 24, 2026 18:19 View deployment

sentry Bot reviewed Apr 24, 2026

View reviewed changes

Comment thread src/sentry/preprod/api/models/snapshots/project_preprod_snapshot_models.py Outdated

ref(preprod): Drop hash-keyed manifest fallback

de8d0a4

NicoHinderling changed the title ~~ref(preprod): Drop hash-keyed manifest fallback and require app_id~~ ref(preprod): Drop hash-keyed manifest fallback Apr 24, 2026

NicoHinderling force-pushed the 04-24-ref_preprod_remove_hash_keyed_manifest_fallback branch from 557c30d to de8d0a4 Compare April 24, 2026 18:36

NicoHinderling mentioned this pull request Apr 24, 2026

feat(preprod): Update snapshot header with approval actions #113959

Merged

vercel Bot deployed to Preview April 24, 2026 18:38 View deployment

update tests

da81756

vercel Bot deployed to Preview April 24, 2026 19:00 View deployment

cursor Bot reviewed Apr 24, 2026

View reviewed changes

Comment thread src/sentry/preprod/snapshots/manifest.py

remove one more todo

25ece5e

vercel Bot deployed to Preview April 24, 2026 19:46 View deployment

NicoHinderling merged commit 66d5562 into master Apr 24, 2026
57 checks passed

NicoHinderling deleted the 04-24-ref_preprod_remove_hash_keyed_manifest_fallback branch April 24, 2026 19:56

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

ref(preprod): Drop hash-keyed manifest fallback#113967

ref(preprod): Drop hash-keyed manifest fallback#113967
NicoHinderling merged 3 commits intomasterfrom
04-24-ref_preprod_remove_hash_keyed_manifest_fallback

NicoHinderling commented Apr 24, 2026 •

edited

Loading

Uh oh!

Uh oh!

github-actions Bot commented Apr 24, 2026

Uh oh!

NicoHinderling commented Apr 24, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Apr 24, 2026

Uh oh!

cursor Bot left a comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

NicoHinderling commented Apr 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Apr 24, 2026

Backend Test Failures

Uh oh!

NicoHinderling commented Apr 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Apr 24, 2026

Backend Test Failures

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

NicoHinderling commented Apr 24, 2026 •

edited

Loading

NicoHinderling commented Apr 24, 2026 •

edited

Loading