fix(preprod): Enforce has_project_access on snapshot detail GET and DELETE#114169
Merged
michelletran-sentry merged 1 commit intomasterfrom Apr 29, 2026
Merged
Conversation
…ELETE OrganizationPreprodSnapshotEndpoint resolved the artifact by project__organization_id but never checked whether the requesting member had access to the artifact's project. Add the has_project_access check on both handlers, mirroring the sibling PreprodArtifactEndpoint pattern with a staff bypass. GH-20078
github-actions
Bot
added
the
Scope: Backend
NicoHinderling
approved these changes
Apr 28, 2026
3 tasks
cleptric
pushed a commit
that referenced
this pull request
May 5, 2026
…ELETE (#114169) OrganizationPreprodSnapshotEndpoint resolved the artifact by project__organization_id but never checked whether the requesting member had access to the artifact's project. Add the has_project_access check on both handlers, mirroring the sibling PreprodArtifactEndpoint pattern with a staff bypass. GH-20078
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OrganizationPreprodSnapshotEndpoint resolved the artifact by project__organization_id but never checked whether the requesting member had access to the artifact's project. Add the has_project_access check on both handlers, mirroring the sibling PreprodArtifactEndpoint pattern with a staff bypass.
GH-20078