chore(groups): Replace category with category_v2#114251
Merged
Conversation
github-actions
Bot
added
the
Scope: Backend
ceorourke
commented
Apr 29, 2026
ceorourke
commented
Apr 30, 2026
malwilley
reviewed
Apr 30, 2026
|
|
||
| if group: | ||
| category_matches = value == group.issue_category or value == group.issue_category_v2 | ||
| category_matches = value == group.issue_category or value == group.issue_category |
Member
There was a problem hiding this comment.
@ceorourke this will actually change the behavior since there are existing database entries with the old categories (Redash query). We would need a migration to make them use the new categories.
In the meantime, you could add temporary code which handles the old categories here (and also in the corresponding workflow_engine condition which has the same problem)
ceorourke
force-pushed
the
ceorourke/ISWF-2348
branch
from
27f46ff to
51ccd4b
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
malwilley
approved these changes
May 1, 2026
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 6769d53. Configure here.
cleptric
pushed a commit
that referenced
this pull request
May 5, 2026
The issue taxonomy flag was removed a while ago but the multiple group categories still needed to be cleaned up. We only use v2 going forward, so this replaces all the group type `category` with `category_v2` but keeps the name category for simplicity. As a temporary fallback in a couple files we still reference the old category type - this can be removed after a migration has been run to remove the old categories from data conditions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The issue taxonomy flag was removed a while ago but the multiple group categories still needed to be cleaned up. We only use v2 going forward, so this replaces all the group type
categorywithcategory_v2but keeps the name category for simplicity.As a temporary fallback in a couple files we still reference the old category type - this can be removed after a migration has been run to remove the old categories from data conditions.