fix(pipeline): Guard against missing installation_id in GitHub install redirect#114363
Merged
evanpurkhiser merged 1 commit intomasterfrom Apr 29, 2026
Conversation
…l redirect When setup_action=install is present but installation_id is missing, reverse() raises NoReverseMatch since the URL pattern requires a \w+ match. Add installation_id to the condition check, matching the same guard already present in the trampoline fallback logic.
evanpurkhiser
requested review from
iamrajjoshi and
oioki
and removed request for
a team
github-actions
Bot
added
the
Scope: Backend
wedamija
approved these changes
Apr 29, 2026
evanpurkhiser
deleted the
evanpurkhiser/fix-pipeline-guard-against-missing-installation-id-in-github-install-redirect
branch
cleptric
pushed a commit
that referenced
this pull request
May 5, 2026
…l redirect (#114363) When `setup_action=install` is present but `installation_id` is missing, `reverse()` raises `NoReverseMatch` since the URL pattern requires a `\w+` match. Adds `installation_id` to the condition check, matching the same guard already present in the trampoline fallback logic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
setup_action=installis present butinstallation_idis missing,reverse()raisesNoReverseMatchsince the URL pattern requires a\w+match. Addsinstallation_idto the condition check, matching the same guard already present in the trampoline fallback logic.