fix(aci): Surface API error detail in edit form save toast#114444
Merged
fix(aci): Surface API error detail in edit form save toast#114444
Conversation
The edit detector form always showed a generic 'Unable to update monitor' message when saving failed, even when the API returned a specific error like 'You do not have permission to perform this action.' Extract the response detail using the same getWorkflowEngineResponseErrorMessage helper already used by the create detector form.
ceorourke
approved these changes
Apr 30, 2026
3 tasks
cleptric
pushed a commit
that referenced
this pull request
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The edit detector form was always showing a generic "Unable to update monitor" toast when saving failed. We have a util that extracts a useful error message, we just weren't using it.
Made the change for both the new and old form logic, but the old one will be gone soon