fix(issues): Use Heading in sentry app external issue modal title#114748
Merged
evanpurkhiser merged 1 commit intomasterfrom May 4, 2026
Conversation
The sentry-app external issue modal (used for Linear and other internal integrations) rendered the modal title as plain text, while the first-party external issue modal (Jira/GitHub/etc.) wraps its title in `<Heading as="h4">`. The modal Header CSS only applies the 20px title size to h1-h6 elements, so the sentry-app variant rendered noticeably smaller. Match the first-party convention so all integration modals share the same title size.
natemoo-re
approved these changes
May 4, 2026
Contributor
📊 Type Coverage Diff✅ No new type safety issues introduced. Coverage: 93.40% |
3 tasks
cleptric
pushed a commit
that referenced
this pull request
May 5, 2026
…14748) The sentry-app external issue modal (used for Linear and other internal-integration "issue link" components) rendered the modal title as plain text, while the first-party external issue modal used for Jira/GitHub/etc. wraps its title in `<Heading as="h4">`. The modal `Header` CSS only applies the 20px title size to `h1`-`h6` elements, so the sentry-app variant rendered noticeably smaller than its first-party siblings. Wrap the title in `<Heading as="h4">` so all integration modals share the same title size.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The sentry-app external issue modal (used for Linear and other internal-integration "issue link" components) rendered the modal title as plain text, while the first-party external issue modal used for Jira/GitHub/etc. wraps its title in
<Heading as="h4">. The modalHeaderCSS only applies the 20px title size toh1-h6elements, so the sentry-app variant rendered noticeably smaller than its first-party siblings.Wrap the title in
<Heading as="h4">so all integration modals share the same title size.