fix(ui): Disable links in project selector avatars#114775
Merged
Conversation
Project selector chips and dropdown rows use IdBadge with hideName, but the badge still wrapped the avatar in a project details link. Pass disableLink in both places so the select behaves like a select instead of hiding links inside it. Co-authored-by: Codex <noreply@openai.com>
Contributor
📊 Type Coverage Diff✅ No new type safety issues introduced. Coverage: 93.40% |
evanpurkhiser
approved these changes
May 4, 2026
3 tasks
cleptric
pushed a commit
that referenced
this pull request
May 5, 2026
Project selector chips and dropdown rows use project badges just for the avatar, but those badges still wrapped the avatar in a project details link. Pass `disableLink` for both the selected multi-value chips and the dropdown options so the selector does not hide links inside its UI. Co-authored-by: Codex <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Project selector chips and dropdown rows use project badges just for the avatar, but those badges still wrapped the avatar in a project details link.
Pass
disableLinkfor both the selected multi-value chips and the dropdown options so the selector does not hide links inside its UI.