fix(backendJsonFormAdapter): Convert disabledReason to disabled string#114847
Merged
fix(backendJsonFormAdapter): Convert disabledReason to disabled string#114847
Conversation
…g for new form system The backend can send a disabledReason string explaining why a field is disabled, but the new form adapter was silently dropping it. Map disabledReason to the disabled: string prop that the new form field components understand, rendering a lock icon with tooltip. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
github-actions
Bot
added
the
Scope: Frontend
Collaborator
Author
|
bugbot run |
Contributor
📊 Type Coverage Diff✅ No new type safety issues introduced. Coverage: 93.40% |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 59ed334. Configure here.
evanpurkhiser
approved these changes
May 5, 2026
…disabled Require both disabled: true and disabledReason to be set before converting to a disabled string. A field with disabledReason but disabled: false should remain enabled. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
disabledReasonbut never passed it through to the new form system's field componentsgetDisabledProp()helper that convertsdisabledReasonintodisabled: string, which the new form field components render as a lock icon with a tooltipTest plan
BackendJsonAutoSaveFormverifyingdisabledReasonrenders lock icon + tooltipBackendJsonSubmitFormverifyingdisabledReasonrenders lock icon + tooltip