fix(ui): Rank trace group by matches with fzf#115032
Merged
Merged
Conversation
The Explore trace Group By dropdown bucketed all partial known fields together, so matching org could keep flag.evaluation.feature.organizations ahead of organization.slug just because of the base option order. Keep the substring filter behavior, but use fzf to rank matches inside that filtered set. Adds a local prefix bump so the obvious org prefix wins without changing global CompactSelect search.
github-actions
Bot
added
the
Scope: Frontend
Contributor
📊 Type Coverage Diff✅ No new type safety issues introduced. Coverage: 93.44% |
nsdeschenes
approved these changes
May 8, 2026
nsdeschenes
added a commit
that referenced
this pull request
May 11, 2026
Continue the work from #115032, and extend it to the visualize dropdown, and column editors. --------- Co-authored-by: OpenAI Codex <noreply@openai.com>
dashed
pushed a commit
that referenced
this pull request
May 11, 2026
Continue the work from #115032, and extend it to the visualize dropdown, and column editors. --------- Co-authored-by: OpenAI Codex <noreply@openai.com>
nikkikapadia
pushed a commit
that referenced
this pull request
May 12, 2026
Follow-up to #109957. Keep the known-field search behavior there, but use fzf to rank matched Group By options so searching org puts organization.slug before flag.evaluation.feature.organizations.
nikkikapadia
pushed a commit
that referenced
this pull request
May 12, 2026
Continue the work from #115032, and extend it to the visualize dropdown, and column editors. --------- Co-authored-by: OpenAI Codex <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #109957. Keep the known-field search behavior there, but use fzf to rank matched Group By options so searching org puts organization.slug before flag.evaluation.feature.organizations.
before
after