chore(explore): Extract and re-use search sorting logic#115194
Merged
nsdeschenes merged 4 commits intoMay 11, 2026
Merged
Conversation
Expose the field definition type union so callers can share typed field definition inputs without deriving it from the function signature.
Share attribute sorting for Explore selector options and search results so known fields rank ahead of arbitrary tags while keeping substring matching behavior.
github-actions
Bot
added
the
Scope: Frontend
Contributor
📊 Type Coverage Diff✅ No new type safety issues introduced. Coverage: 93.47% |
Clarify when to use the searched and known attribute sorting helpers in Explore field pickers. Co-Authored-By: OpenAI Codex <noreply@openai.com>
Contributor
Author
|
@sentry review |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit e1c618d. Configure here.
Allow the shared visualize dropdown to receive the field definition type used for search scoring. Pass log definitions from the logs toolbar so known-field boosts use the correct dataset. Co-Authored-By: OpenAI Codex <noreply@openai.com>
scttcper
approved these changes
May 8, 2026
nsdeschenes
deleted the
nd/chore-explore-extract-and-re-use-search-sorting-logic
branch
dashed
pushed a commit
that referenced
this pull request
May 11, 2026
Continue the work from #115032, and extend it to the visualize dropdown, and column editors. --------- Co-authored-by: OpenAI Codex <noreply@openai.com>
nikkikapadia
pushed a commit
that referenced
this pull request
May 12, 2026
Continue the work from #115032, and extend it to the visualize dropdown, and column editors. --------- Co-authored-by: OpenAI Codex <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continue the work from #115032, and extend it to the visualize dropdown, and column editors.