ref(onboarding): adopt useModal in onboarding flows#115127
Merged
evanpurkhiser merged 1 commit intoMay 19, 2026
Merged
Conversation
github-actions
Bot
added
the
Scope: Frontend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 5c33b8a. Configure here.
Contributor
📊 Type Coverage Diff✅ No new type safety issues introduced. Coverage: 93.55% |
evanpurkhiser
force-pushed
the
evanpurkhiser/ref-onboarding-adopt-usemodal-in-onboarding-flows
branch
from
5c33b8a to
e295523
Compare
evanpurkhiser
force-pushed
the
evanpurkhiser/ref-onboarding-adopt-usemodal-in-onboarding-flows
branch
from
e295523 to
093af22
Compare
evanpurkhiser
force-pushed
the
evanpurkhiser/ref-onboarding-adopt-usemodal-in-onboarding-flows
branch
from
093af22 to
ee3f2f0
Compare
evanpurkhiser
commented
May 18, 2026
|
|
||
| createProjectInstance = mockCreateProjectHook(); | ||
| mockUseCreateProject.mockReturnValue(createProjectInstance); | ||
| (useModal as jest.Mock).mockReturnValue({openModal: mockOpenModal}); |
Member
Author
There was a problem hiding this comment.
This can be jest.mocked(useModal) I think?
evanpurkhiser
force-pushed
the
evanpurkhiser/ref-onboarding-adopt-usemodal-in-onboarding-flows
branch
from
ee3f2f0 to
3afdb49
Compare
evanpurkhiser
force-pushed
the
evanpurkhiser/ref-onboarding-adopt-usemodal-in-onboarding-flows
branch
from
3afdb49 to
b4fdb96
Compare
scttcper
approved these changes
May 19, 2026
evanpurkhiser
deleted the
evanpurkhiser/ref-onboarding-adopt-usemodal-in-onboarding-flows
branch
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adopts the
useModalhook from@sentry/scraps/modalin place of importingopenModalfromsentry/actionCreators/modal, following up on the GlobalModal adoption in #114447.The migration was applied by an
ast-grepcodemod that:const {openModal} = useModal();at the top of each enclosing function component or custom hook.@sentry/scraps/modalimport).openModalto any wrappinguseCallback/useEffect/useMemodependency array, since the destructured value is no longer module-stable.Action-creator helpers (e.g.
openInviteModal) and other call sites where a hook can't be used are left alone. This PR is one of several split per CODEOWNERS group.